Adopt jspecify + NullAway null-checking on fdb-record-layer-icu - #4578
Draft
arnaud-lacurie wants to merge 1 commit into
Draft
Conversation
Adds jspecify plus NullAway (via net.ltgt.errorprone), scoped to this module only, following the same pattern as fdb-relational-grpc and fdb-relational-jdbc. com.apple.foundationdb.record.icu is marked @NullMarked; the module's only two javax.annotation.Nonnull usages are removed (non-null is now the default under @NullMarked). No javax.annotation.Nullable usages existed in this tiny module, and NullAway surfaced no undocumented nullability or latent bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5th of a 14-PR stack adopting jspecify + NullAway null-checking, stacked on #4577 (
fdb-test-utils). Same treatment applied tofdb-record-layer-icu. See inline comments for specific findings.