Skip to content

Implement single cluster recovery command - #2541

Open
johscheuer wants to merge 4 commits into
FoundationDB:mainfrom
johscheuer:kubectl-fdb-recover-single-fdb
Open

johscheuer wants to merge 4 commits into
FoundationDB:mainfrom
johscheuer:kubectl-fdb-recover-single-fdb

Conversation

@johscheuer

Copy link
Copy Markdown
Member

Description

Implement single cluster recovery command for cases where a majority of coordinators are lost.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Discussion

This is a breaking change as the recovery commands are put under one subcommand.

Testing

Added e2e tests, but will do some additional validation.

Documentation

Will be updated.

Follow-up

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: ee7cdba
  • Duration 1:54:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
johscheuer force-pushed the kubectl-fdb-recover-single-fdb branch from ee7cdba to 1ebebc1 Compare August 27, 2026 17:51
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 1ebebc1
  • Duration 1:56:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 9229a4d
  • Duration 1:47:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
johscheuer marked this pull request as ready for review September 1, 2026 16:49
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: e54c2b8
  • Duration 2:14:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Sep 3, 2026
@johscheuer johscheuer reopened this Sep 3, 2026
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: e54c2b8
  • Duration 1:54:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@nicmorales9 nicmorales9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bag-o-nits but it looks like a good improvement and I don't have any serious concerns

Comment thread e2e/fixtures/fdb_cluster.go Outdated
Comment thread e2e/fixtures/fdb_cluster.go Outdated
Comment thread e2e/fixtures/fdb_cluster.go
Comment thread e2e/test_operator_plugin/operator_plugin_test.go Outdated
Comment thread e2e/test_operator_plugin/operator_plugin_test.go
Comment thread kubectl-fdb/cmd/recover.go Outdated
Comment thread kubectl-fdb/cmd/recover.go
Comment thread kubectl-fdb/cmd/recover.go
Comment thread kubectl-fdb/cmd/recover_single_dc_cluster.go Outdated
Comment thread kubectl-fdb/cmd/recover_single_dc_cluster.go
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 7975249
  • Duration 2:11:19
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
johscheuer force-pushed the kubectl-fdb-recover-single-fdb branch from 7975249 to a5a519c Compare September 8, 2026 12:04
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: a5a519c
  • Duration 2:08:21
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants