Fix/pending#1
Merged
Merged
Conversation
- home.tsx: createSignal received a bare function as initial value — a real latent bug, not just a type error: the function itself was stored as the signal value, so the saved home model (forge_home_model_v2) was never restored. Wrapped in an IIFE. - utils/server.ts: Bun's 'typeof fetch' requires a 'preconnect' member our wrapper (and a config-provided fetch) doesn't have; the SDK only calls it. Cast the ternary instead of annotating. tsgo -b: 0 errors (was 2). Prerequisite for making CI a required check.
Three required-check candidates for the protect-main ruleset: - forge-ui typecheck (bun workspace install + tsgo) - forge-server syntax + tests (compileall, pip install, pytest — 62 tests, verified passing locally; pytest/pytest-asyncio added to requirements-dev.txt, they were missing) - runner-image script syntax (bash -n + node --check) CODEOWNERS: default '*' rule routes every PR to @Forgeweb-ai/maintainers (replace with real team/usernames), with explicit entries for high blast-radius paths (runner-image, runner/, opencode/, .github/). ci.yml YAML-validated; all three job command sets executed locally.
… CODEOWNERS, freeze note, drop forgeweb.ai, supabase scratch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.