Skip to content

Fix fjall fuzz reset slowdown#1024

Merged
tomusdrw merged 1 commit into
mainfrom
td-fjall-fast-partition-reset
Jul 11, 2026
Merged

Fix fjall fuzz reset slowdown#1024
tomusdrw merged 1 commit into
mainfrom
td-fjall-fast-partition-reset

Conversation

@tomusdrw

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Improved the reliability of periodic Fjall keyspace rebuilding during fuzz testing.
    • Standardized rebuild timing across supported Fjall storage modes.
  • Chores

    • Updated the Fjall storage dependency to version 0.5.0.

Walkthrough

Updates @fjall-js/fjall from 0.4.1 to 0.5.0. Replaces the hybrid-specific rebuild interval with a shared interval of 50 and applies it to both fjall-hybrid and full-fjall reset paths, including keyspace close, wipe, and reopen operations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: skoszuta, mateuszsikora

Poem

A rabbit saw the keyspaces bloom,
Fifty hops to clear the room.
Fjall grew fresh, the resets flew,
Hybrid and full paths shared the cue.
“Nibble on!” the bunny cheered.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so there is no meaningful description to assess. Add a brief description of the fjall fuzz reset change and its purpose.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: reducing fjall fuzz reset slowdown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-fjall-fast-partition-reset

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/jam/node/main-fuzz.ts (1)

40-41: 🚀 Performance & Scalability | 🔵 Trivial

Add a regression measurement for the shared interval.

50 now controls rebuild frequency for both backends. Add benchmark coverage for reset latency and database growth/read amplification so this tuning does not improve one backend while regressing the other.

As per coding guidelines, performance-critical tuning decisions should be measured or benchmarked.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/jam/node/main-fuzz.ts` around lines 40 - 41, Add regression
benchmark coverage for the shared REBUILD_FJALL_KEYSPACE_EVERY interval,
measuring reset latency, database growth, and read amplification independently
for both backends. Ensure the benchmark exercises the interval value and
compares the results so tuning the shared constant cannot improve one backend
while regressing the other.

Sources: Coding guidelines, Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/jam/node/main-fuzz.ts`:
- Around line 40-41: Add regression benchmark coverage for the shared
REBUILD_FJALL_KEYSPACE_EVERY interval, measuring reset latency, database growth,
and read amplification independently for both backends. Ensure the benchmark
exercises the interval value and compares the results so tuning the shared
constant cannot improve one backend while regressing the other.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cdd002d3-889c-475f-a233-584c89f04994

📥 Commits

Reviewing files that changed from the base of the PR and between 411c828 and 7aedf1c.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • packages/jam/database-fjall/package.json
  • packages/jam/node/main-fuzz.ts

@tomusdrw tomusdrw merged commit 9d838d3 into main Jul 11, 2026
16 of 17 checks passed
@tomusdrw tomusdrw deleted the td-fjall-fast-partition-reset branch July 11, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant