Add comprehensive component tests for analytics charts - #882
Merged
Merged
Conversation
Created charts.test.tsx with 100% coverage of all render branches in AnalyticsCharts. Tests include: all six empty-state branches (series, token distribution, status breakdown, top recipients, top tokens, unlock progress), populated data rendering for area/pie/bar charts with correct element counts, token symbol display and formatting, stream count singular/plural forms, unlock progress percentage calculation (0%, 50%, 100%), and card title/description rendering. Uses React Testing Library to verify UI elements render correctly for each state. Add comprehensive component tests for navbar component Created navbar.test.tsx with full coverage of active-link highlighting, network/theme dropdown state changes, and network-mismatch banner conditional rendering. Tests include: highlighting correct active link per route (handles nested routes), network dropdown selection updating state (testnet/mainnet), theme dropdown selection (light/dark/system), network-mismatch banner only rendering when isConnected && networkMismatch with correct wallet/network display, offline status indicator, new stream button disabled state on network mismatch, mobile nav consistency, and presence of required child components (Brand, NotificationBell, ConnectWalletButton). Includes comprehensive mocking of navigation, theme, network, wallet, and online-status hooks. Closes FlowwStar#644 Closes FlowwStar#645
|
@Kingsman-99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Kingsman-99
had a problem deploying
to
staging
September 28, 2026 11:25 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created charts.test.tsx with 100% coverage of all render branches in AnalyticsCharts. Tests include: all six empty-state branches (series, token distribution, status breakdown, top recipients, top tokens, unlock progress), populated data rendering for area/pie/bar charts with correct element counts, token symbol display and formatting, stream count singular/plural forms, unlock progress percentage calculation (0%, 50%, 100%), and card title/description rendering. Uses React Testing Library to verify UI elements render correctly for each state.
Add comprehensive component tests for navbar component
Created navbar.test.tsx with full coverage of active-link highlighting, network/theme dropdown state changes, and network-mismatch banner conditional rendering. Tests include: highlighting correct active link per route (handles nested routes), network dropdown selection updating state (testnet/mainnet), theme dropdown selection (light/dark/system), network-mismatch banner only rendering when isConnected && networkMismatch with correct wallet/network display, offline status indicator, new stream button disabled state on network mismatch, mobile nav consistency, and presence of required child components (Brand, NotificationBell, ConnectWalletButton). Includes comprehensive mocking of navigation, theme, network, wallet, and online-status hooks.
Closes #644
Closes #645
name: Pull request
about: Describe a focused change and how it was verified
title: 'feat: '
labels: enhancement
Issue
Closes #
Summary
Describe the user or maintainer-facing change.
Changes
Test plan
Checklist