docs: add JSDoc comments to recurring, address-book, error-messages, and use-streams Issues/772 773 774 776 - #880
Merged
Austinaminu2 merged 4 commits intoSep 27, 2026
Conversation
|
@kossyomma-beep Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds JSDoc doc comments to all previously undocumented exported functions across four frontend utility files, completing a documentation pass requested in the linked issues.
Changes
lib/recurring.ts— added doc comments to 5 exports:getRecurringRules— describes SSR safety and return shapesaveRecurringRule— documents the 25-entry cap and deduplication behaviourremoveRecurringRule— documents the streamId-based removalgetUpcomingRenewals— explains the future-only filter and sort ordercreateRenewalPreset— documents parameters, side-effect (auto-saves), and return valuelib/address-book.ts— added doc comments to 5 exports:getAddressBookEntries— describes sort order and SSR safetyaddAddressBookEntry— documents ID/timestamp generation, trimming, deduplication, and 50-entry capupdateAddressBookEntry— documents partial-patch semantics and null return on missdeleteAddressBookEntry— documents silent no-op on missing IDtouchAddressBookEntry— documents the upsert logic (update vs. create), field fallback rules, and blank-address guardlib/error-messages.ts— added doc comments to 3 exports:mapError— explains the pattern-matching strategy (RegExp vs. string, first-match-wins, declaration order), the Soroban error-code mapping, and the known accuracy limitation tracked in bug: error message mapper never matches real on-chain Soroban contract error codes #231/bug: error message mapper never matches real on-chain Soroban contract error codes #287categoryLabel— documents display purpose and return valuescategoryColor— documents Tailwind class format and light/dark mode pairhooks/use-streams.ts— added doc comments to 3 exports:invalidateStreams— explains the listener-bus mechanism and when to call ituseStreams— fully documents all return fields including the non-obviousstale(offline cache fallback) andisRefreshingAfterHidden(tab-focus refresh indicator) fields, plus polling behaviour and optionsuseStream— documents single-stream fetch semantics, absence of polling, and return shapeIssues
Closes #772
Closes #773
Closes #774
Closes #776