Skip to content

docs: add deprecation metadata#159

Merged
paodb merged 1 commit into
masterfrom
deprecation-metadata
Jun 26, 2026
Merged

docs: add deprecation metadata#159
paodb merged 1 commit into
masterfrom
deprecation-metadata

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated deprecation notices for several legacy APIs to indicate they are scheduled for removal in future releases.
    • No runtime behavior or user-facing functionality was changed.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db4cd298-45e3-4fa6-9df3-2f50cef73e31

📥 Commits

Reviewing files that changed from the base of the PR and between 9515ad3 and 18e2413.

📒 Files selected for processing (2)
  • base/src/main/java/com/flowingcode/vaadin/addons/demo/EnhancedRouteTabs.java
  • base/src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java

Walkthrough

The PR updates deprecation annotations on three demo methods to include forRemoval = true and version metadata. No method logic or signatures changed.

Changes

Demo deprecation annotations

Layer / File(s) Summary
Legacy tab deprecation metadata
base/src/main/java/com/flowingcode/vaadin/addons/demo/EnhancedRouteTabs.java
addLegacyTab(String, Component) now uses @Deprecated(forRemoval = true, since = "4.1.0").
Theme attribute deprecation metadata
base/src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java
getThemeAttribute() and applyThemeAttribute(Element, String) now use @Deprecated(forRemoval = true, since = "5.2.0").

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding deprecation metadata to existing deprecated methods.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deprecation-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@javier-godoy javier-godoy requested review from paodb and scardanzan June 26, 2026 19:26
@javier-godoy javier-godoy marked this pull request as ready for review June 26, 2026 19:26
@paodb paodb merged commit fd1c9cb into master Jun 26, 2026
2 of 3 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jun 26, 2026
@paodb paodb deleted the deprecation-metadata branch June 26, 2026 20:26
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants