Remove scenario IDs#281
Merged
patricklucas merged 2 commits intoFIXTradingCommunity:v1-1-RC3from Mar 12, 2026
Merged
Conversation
Also, clean up and fix invalid keyrefs. Fixes FIXTradingCommunity#271
Member
|
Agree with the recommendation to make top level scenario definitions optional as that also increases backward compatibility with Orchestra v1.0 where they simply did not exist. |
patricklucas
commented
Mar 11, 2026
Comment on lines
+66
to
+69
| <xs:key name="codeIdKey"> | ||
| <xs:selector xpath="fixr:code"/> | ||
| <xs:field xpath="@id"/> | ||
| </xs:key> |
Collaborator
Author
There was a problem hiding this comment.
Ah, also I added this to enforce that code IDs within a code set are unique. Let me know if you want me to open a separate issue for that.
Member
There was a problem hiding this comment.
Good catch, but should be a separate issue. Same for the optional scenario definitions on the top level. The Technical Proposal will have separate sections for those changes to explain the rationale.
patricklucas
commented
Mar 11, 2026
Comment on lines
-138
to
-141
| <xs:key name="typeKey"> | ||
| <xs:selector xpath="."/> | ||
| <xs:field xpath="@type|@codeSet"/> | ||
| </xs:key> |
Collaborator
Author
There was a problem hiding this comment.
Moved this up a level to fieldTypeOrCodeSetKey to match the pattern of other keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, clean up and fix invalid keyrefs.
Fixes #271
I found that several of the keyref declarations were not actually valid, because instead of using selector e.g.
fixr:codeSets/fixr:codeSetthey just usedfix:codeSet, which would not match anything. I believe I have them working as intended now.One thing, however, was that I've tentatively removed the check that a scenario attribute refers to a scenario defined at the top level.
<fixr:scenarios><fixr:scenario name="base"/></fixr:secnarios>, even if they do not otherwise use scenarios