chore: 4 dependabot PRs failing lint/pretty since 08-09/09-02/09-03, two newer siblings pass clean #129

Activity

1. birme

   self-assigned this

   on Sep 29, 2026
2. birme commented on Sep 29, 2026

   

   birme

   on Sep 29, 2026

   Contributor

   More actions

   Root cause diagnosed by today's daily-backlog-pr run (reproduced locally) — confirmed the drift hypothesis; no source/config fix on main is needed.

   The failure: all four stale PRs fail on the same single file, src/index.ts, for one prettier/prettier violation (line ~225): the single-line

   this.peer = new RTCPeerConnection({ iceServers: this.iceServers, ...this.rtcConfiguration });

   exceeds prettier's print width and must be broken across lines. lint fails because .eslintrc sets prettier/prettier: error; pretty fails on the same issue; ts (tsc --noEmit) passes because it's purely a formatting matter — which is exactly the lint+pretty-fail / ts-pass pattern reported.

   Why the split: that line was reformatted to the prettier-clean multi-line form by commit dbd536b (#113, 2026-09-07). The four failing PRs (#102/#110/#111/#112) all branch from 3f94e63 (2026-06-23), before dbd536b, so they still carry the unformatted line. The two passing PRs (#123/#124) branch from 471ace7 (2026-09-08), after it. Prettier/eslint config and the lint/pretty scripts did not change in that window — the drift is solely the reformatted source line.

   Verified fix: locally merging current origin/main into a failing branch (throwaway, never pushed) took both npm run lint and npm run pretty to exit 0.

   Action taken: posted @dependabot rebase on #102, #110, #111, #112. Dependabot will rebase each onto current main (pulling in dbd536b), after which lint/pretty/ts go green and they can be merged normally. Since dependabot's rebase + CI re-run is asynchronous, this run cannot merge them; unassigning and moving back to Ready so a follow-up run (or a maintainer) can merge the four once CI is green.
3. birme

   assigned

   birme

   and unassigned

   birme

   on Sep 29, 2026
4. birme commented on Sep 30, 2026

   

   birme

   on Sep 30, 2026

   Contributor

   More actions

   Resolved by the daily-backlog-pr automation. As predicted in the issue, the lint/pretty failures
   were main-side config/lockfile drift, not the bumped packages: dependabot has since rebased all
   four PRs onto current main and they now pass lint, pretty, and ts clean and merge cleanly.

   Merged:

   • chore(deps): bump brace-expansion from 1.1.12 to 1.1.21 #102 brace-expansion → 1.1.21
   • chore(deps): bump fast-uri from 3.1.2 to 3.1.8 #110 fast-uri → 3.1.8
   • chore(deps): bump @xmldom/xmldom from 0.8.13 to 0.8.15 #111 @xmldom/xmldom → 0.8.15
   • chore(deps-dev): bump browserslist from 4.28.2 to 4.29.2 #112 browserslist → 4.29.2

   All four are package-lock.json-only bumps (no source or workflow-file changes). Closing.
5. birme

   closed this as completedon Sep 30, 2026