Repository navigation
feat: add reusable Tabs component and tab the settings modal - #735
Merged
Merged
Conversation
…ngs modal Add a generic, accessible Tabs component (tablist/tab/tabpanel roles, keyboard navigation, controlled + uncontrolled usage) under src/components/tabs. Use it in the calls-page user settings modal to split the existing settings into "Devices" and "Profile" tabs, threading hideUsername/hideDevices through the UserSettings wrapper. Refs #516 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
code-reviewer verdict: LGTM (self-authored PR; recorded as a marker since GitHub blocks state-bearing self-review). Independent review re-ran typecheck/lint/test — all green (362 tests). No blocking/major findings. Confirmed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tabscomponent (src/components/tabs/) withrole="tablist"/"tab"/"tabpanel",aria-selected, rovingtabIndex, and arrow/Home/End keyboard navigation. Supports controlled and uncontrolled use plus disabled tabs; all panels stay mounted so form state is preserved across tab switches.hideUsername/hideDevicesprops through theUserSettingswrapper additively, so existingUserSettingsFormbehaviour and tests are unchanged.Test plan
npm test— 44 files / 362 tests green, incl. 7 new Tabs tests)npm run typecheck)npm run lint)Closes #516
🤖 Generated with Claude Code