[HOLD for feature release] [No QA] Add help site article for CSV company card import#86779
[HOLD for feature release] [No QA] Add help site article for CSV company card import#86779
Conversation
Adds a new help article covering the CSV file import flow for company cards introduced in PR #80636. Also updates the Direct-feeds article to mention the new import option in the bank selection step. Co-authored-by: Mario Mazzotti <MarioExpensify@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://11b77936.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
melvin-bot
bot
requested review from
CortneyOfstad
and removed request for
a team
|
@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 5. **Pick your bank:** | ||
| - If you’re in the U.S., select your bank from the list or choose **Other** to see additional banks supported by Plaid. | ||
| - For international members in supported countries, choosing **Direct feed** will automatically launch the Plaid connection process. | ||
| - To upload transactions from a file instead, select **Import transactions from file**. Learn how to [import company card transactions from a CSV file](/articles/new-expensify/connect-credit-cards/Import-Company-Cards-From-CSV). |
There was a problem hiding this comment.
Cross-linking violation: Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting), links must not be placed inside numbered step instructions: "Do not place links inside numbered step instructions. Do not interrupt procedural flow with inline links."
Move the cross-link sentence outside of the numbered step list -- for example, place it in a separate paragraph after the step sequence or in a note below the steps.
| The card feed appears with the layout name you entered during setup. You can manage the feed and assign cards the same way you would for a direct or commercial feed. Learn how to [assign and manage corporate cards](/articles/new-expensify/connect-credit-cards/Assign-and-Manage-Cards). | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Cross-linking violation: Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting), links must use relative links only: "Use relative links only. Do not use full URLs."
The link path /articles/new-expensify/connect-credit-cards/Assign-and-Manage-Cards looks like a relative path, which is correct. However, please verify the target file actually exists at that path -- I don't see a file named Assign-and-Manage-Cards.md in this directory, which would result in a broken link.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a well-structured new article for importing company card transactions from a CSV file and a cross-link from the existing Direct Feeds article. The new article follows governance conventions closely: it solves a single workflow, uses task-based headings, includes proper YAML metadata, and provides clear sequential steps. A small number of style-compliance items are worth addressing. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
|
||
| ## How to import company card transactions from a CSV file | ||
|
|
||
| 1. Go to **Workspaces > [Workspace Name] > Company Cards**. |
There was a problem hiding this comment.
Naming/UI label consistency: The navigation path uses "Company Cards" (capital C), but the existing Direct-feeds.md article in this same directory consistently uses "Company cards" (lowercase c). Per HELPSITE_NAMING_CONVENTIONS.md, UI labels must match the exact capitalization shown in the product. Please verify the actual UI and align -- the existing articles suggest the correct label is Company cards.
|
|
||
| After a successful import, the transactions are added to the workspace and cards appear on the **Company Cards** page. You can then assign cards to workspace members. | ||
|
|
||
| The card feed appears with the layout name you entered during setup. You can manage the feed and assign cards the same way you would for a direct or commercial feed. Learn how to [assign and manage corporate cards](/articles/new-expensify/connect-credit-cards/Assign-and-Manage-Cards). |
There was a problem hiding this comment.
Naming/UI label consistency: Same capitalization issue as step 1 -- "Company Cards" should likely be "Company cards" (lowercase c) to match the actual UI label. Verify against the product and align with the existing Direct-feeds.md article in this directory.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c79750d2a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 1. Go to **Workspaces > [Workspace Name] > Company Cards**. | ||
| 2. Click **Add cards**. | ||
| 3. Select **Import transactions from file**. |
There was a problem hiding this comment.
The workflow here omits required screens in the actual app flow: after Add cards, users are first taken through country/feed-type selection, and the Import transactions from file choice is only shown later in the bank-selection step (AddNewCardPage step routing plus SelectCountryStep → SelectFeedType → SelectBankStep). As written, step 3 is not available immediately after step 2, so readers can’t follow these instructions end-to-end and may assume the feature is missing.
Useful? React with 👍 / 👎.
stephanieelliott
changed the title
3 participants
Explanation of Change
PR #80636 added a new CSV file import flow for company cards in New Expensify, but the help site had no corresponding documentation. This PR adds a new help article covering the CSV import workflow and updates the existing Direct-feeds article to mention the new option.
Changes:
docs/articles/new-expensify/connect-credit-cards/Import-Company-Cards-From-CSV.md): Documents the full CSV import flow — from selecting "Import transactions from file" through column mapping and import. Includes sections on advanced fields, post-import behavior, and FAQ for common errors.docs/articles/new-expensify/connect-credit-cards/Direct-feeds.md): Added a bullet to the bank selection step mentioning the new "Import transactions from file" option with a cross-link to the new article.Both articles follow the guidelines in
HELPSITE_NAMING_CONVENTIONS.md,HELP_AUTHORING_GUIDELINES.md, andTEMPLATE.md.Fixed Issues
$ #80636
Tests
/articles/new-expensify/connect-credit-cards/Import-Company-Cards-From-CSVOffline tests
N/A — documentation-only changes.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — documentation-only changes
Android: mWeb Chrome
N/A — documentation-only changes
iOS: Native
N/A — documentation-only changes
iOS: mWeb Safari
N/A — documentation-only changes
MacOS: Chrome / Safari
N/A — documentation-only changes