Fix/launch template unsafe quoting, and performance improvements#542
Open
tcutts wants to merge 4 commits intoExaWorks:mainfrom
Open
Fix/launch template unsafe quoting, and performance improvements#542tcutts wants to merge 4 commits intoExaWorks:mainfrom
tcutts wants to merge 4 commits intoExaWorks:mainfrom
Conversation
Collaborator
|
Thank you @tcutts! I'll copy the PR to our repo to let our distributed tests run and merge this once that happens. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
+ Coverage 72.80% 75.01% +2.20%
==========================================
Files 89 91 +2
Lines 4012 4567 +555
==========================================
+ Hits 2921 3426 +505
- Misses 1091 1141 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unsafe shell variable expansions and quoting in launcher scripts
All launcher scripts (aprun_launch.sh, jsrun_launch.sh, mpi_launch.sh, multi_launch.sh, single_launch.sh, srun_launch.sh) and the test launcher.sh had several quoting issues that would cause failures when paths contain spaces. This PR fixes them all:
In launcher_lib.sh:
For 10,000 lines of output this saves about 18 seconds of execution time (benchmarked on an M1 Macbook)