fix:(feat): use random nonce for encryption key generation - #151
Open
odaysec wants to merge 1 commit into
Open
Conversation
Use a non-hard-coded nonce seed when building the encryption key+nonce bundle. fix `generate_encryption_key_nonce()` (around lines 1096–1102), generate 4 random bytes using the same `SystemRandom`, convert them into a `u32` (e.g., little-endian), and pass that value to `get_encryption_key_with_nonce(...)` instead of literal `1`. This keeps the existing data format and flow unchanged (still `u32` nonce + key bytes), avoids introducing new dependencies, and resolves the hard-coded cryptographic value. Also handle `rand.fill(...)` result for nonce bytes the same way existing code handles key generation (without changing function signatures/behavior).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a non-hard-coded nonce seed when building the encryption key+nonce bundle. fix
generate_encryption_key_nonce()(around lines 1096–1102), generate 4 random bytes using the sameSystemRandom, convert them into au32(e.g., little-endian), and pass that value toget_encryption_key_with_nonce(...)instead of literal1. This keeps the existing data format and flow unchanged (stillu32nonce + key bytes), avoids introducing new dependencies, and resolves the hard-coded cryptographic value. Also handlerand.fill(...)result for nonce bytes the same way existing code handles key generation (without changing function signatures/behavior).