Skip to content

[AGW-287] Add the near-well equipment description to the alfacase - #574

Merged
esss-jenkins merged 1 commit into
masterfrom
fb-AGW-287-Create-the-near-well-equipment-input-model
Oct 8, 2026
Merged

esss-jenkins merged 1 commit into
masterfrom
fb-AGW-287-Create-the-near-well-equipment-input-model

Conversation

@alrossa

@alrossa alrossa commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Adds the near-well equipment to the alfacase: NearWellEquipmentDescription, the near_wells attribute of EquipmentDescription, and the NearWellCompositionType enum, which says whether a composition is given as an oil mass fraction or an oil saturation.

The near-well's fluid is also included in the fluid reference check, on pipes and on wells.

🤖 Generated with Claude Code

@alrossa
alrossa requested a review from BeneBr October 5, 2026 19:19
@alrossa
alrossa force-pushed the fb-AGW-287-Create-the-near-well-equipment-input-model branch from bde000a to 9d45b02 Compare October 5, 2026 20:22
Comment thread src/alfasim_sdk/_internal/alfacase/case_description.py
Comment thread src/alfasim_sdk/_internal/alfacase/case_description.py
Comment thread src/alfasim_sdk/_internal/alfacase/case_description.py Outdated
Comment thread tests/alfacase/test_case_description.py Outdated
Comment thread tests/alfacase/test_case_description.py Outdated
Comment thread tests/alfacase/test_case_description.py Outdated
Comment thread tests/common_testing/alfasim_sdk_common_testing/filled_case_descriptions.py Outdated
Comment thread tests/common_testing/alfasim_sdk_common_testing/filled_case_descriptions.py Outdated
@alrossa
alrossa force-pushed the fb-AGW-287-Create-the-near-well-equipment-input-model branch from e658996 to 9d45b02 Compare October 6, 2026 11:03
@alrossa
alrossa requested a review from BeneBr October 6, 2026 12:03
Comment thread src/alfasim_sdk/_internal/alfacase/case_description.py Outdated

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrossa please always add me as reviewers as well. 👍

@alrossa

alrossa commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

regarding @nicoddemus comment
@nicoddemus, sure.
Actually it was suppose to be in "Draft mode" since the idea was to ask for @BeneBr opinion whether I was adding the near-well model properlly, I mean, the task's "pig picture" (notice this is the first task regarding a new alfasim equipment I tackle). After his OK, I would do a local review using the review skill, and finally set the PR as "Ready to review".
My bad

@nicoddemus

Copy link
Copy Markdown
Member

No problem!

@alrossa
alrossa force-pushed the fb-AGW-287-Create-the-near-well-equipment-input-model branch 3 times, most recently from 40522eb to 9385a90 Compare October 6, 2026 21:51
@alrossa
alrossa requested review from BeneBr and nicoddemus October 6, 2026 21:57
The near-well is a new equipment, a two-phase (water and oil) reservoir
simulation around the well, so an alfacase needs a place to state it.

Add NearWellEquipmentDescription and the near_wells attribute of
EquipmentDescription. The description holds what the user enters: the
position, the PVT fluid and the rock material by name, the radial domain
and its mesh, porosity and permeability, the Corey relative permeability,
the initial conditions and the reservoir state at the influence radius.

Each composition, initial and reservoir, is one value plus the new
NearWellCompositionType, which says whether it is an oil mass fraction or
an oil saturation.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@alrossa
alrossa force-pushed the fb-AGW-287-Create-the-near-well-equipment-input-model branch from 9385a90 to d0cb18c Compare October 6, 2026 23:48
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

Comment thread src/alfasim_sdk/_internal/alfacase/case_description.py
@alrossa
alrossa requested a review from BeneBr October 7, 2026 10:44
@esss-jenkins
esss-jenkins merged commit daaa048 into master Oct 8, 2026
7 checks passed
@esss-jenkins
esss-jenkins deleted the fb-AGW-287-Create-the-near-well-equipment-input-model branch October 8, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants