Repository navigation
don't hardcode EESSI version environments #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smoors
wants to merge
11
commits into
EESSI:main
Choose a base branch
from
smoors:eessi-vers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
61602b3
don't hardcode EESSI version environments
09be518
warn instead of error if no EESSI versions are found
075dba8
fix gh workflow
68c4669
add add_eessi_versions param
2a16faf
update
266486c
add info and warning messages
4eed108
fixes
1e9e5e3
add NO_EESSI marker
a7177ba
fix
7bd05a3
use reframe machinery for lmod; convert error to warning for missing …
a2dfbef
Merge branch 'main' into eessi-vers
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit inconsistent: if we can't detect EESSI versions because there is no
LMOD_CMD, it's a hard error. If we can't detect EESSI versions because there is a module command, but yourcmdhas simply not returned any EESS modules (e.g. because theMODULEPATHwasn't set correctly) it's a warning. We should make this consistent, but... with what?You could say: it's an error, because the user specified
add_eessi_versions=Truein their config (well, implicitely, since it is the default). If you can't detect EESSI environments, we cannot add them, and since that was requested, it is an error.One could also argue that this is a breaking change, and that raising an error would be 'too breaking'. I.e. without changing any of the defaults, if my
MODULEPATHdoesn't contain EESSI (or if I don't have a modulecommand), I now suddenly get a hard error.I'm not sure which way to go...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's probably no clear answer, but the way i see it:
a solution could be to add a ReFram variable, say
no_eessi_modules_found_policy, similar torequired_mem_per_node_undefined_policyandreadonly_files_undefined_policy. then each user can decide if they want an error or a warning.what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, maybe I'm just bikeshedding. I was really thinking about it from a single function perspective: if you ahve a function that is supposed to 'get' the EESSI versions, and it didn't find any, I thought that was a (hard) failure as well. I.e. function didn't return what it was supposed to return. But I guess that's not the case: it did return what it was supposed to return, namely 'there are no EESSI modules on this system' (but we can still test the local ones).
Fine, let's just keep it like this - maybe generalize the
LMOD_CMDto other module systems. I do still think that a hard error on a system that has Environment Modules instead of Lmod is... too harsh.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, this conversation is resolve,d we'll pick up the LMOD_CMD thing at that line :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to use warning for the missing Lmod, since other module systems may stil be available and so local modules can still be tested. so both are now a warning. also using the ReFrame machinery for the modules sytem now.
7bd05a3