Send the Reply-To a message asks for - #9
Merged
Merged
Conversation
A message could set `reply_to` and the backend would drop it: the payload was built from the sender, the recipients, the content and the attachments, so a reply went to the from-field address, which is typically unattended. GetResponse names a reply-to the way it names a sender, by the id of a from-field registered on the account, so the address has to be in `GETRESPONSE_ADDRESSES` like `from_email` — an unregistered one is refused rather than sent under the sender's id. Django allows a list where the API holds one, so a second address is refused too rather than one of them silently picked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012EQ7nV1HE5GJjQ3JTP4hQ6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A message could set
reply_toand the backend would drop it: the payload was built from the sender, the recipients, the content and the attachments, so a reply went to the from-field address, which is typically unattended.GetResponse names a reply-to the way it names a sender, by the id of a from-field registered on the account, so the address has to be in
GETRESPONSE_ADDRESSESlikefrom_email— an unregistered one is refused rather than sent under the sender's id. Django allows a list where the API holds one, so a second address is refused too rather than one of them silently picked.Also fixes the resolver's error message, which said
Given from_email (...)on a path that now serves two fields — misleading for a caller whosefrom_emailis registered and whose reply address is not.README.mddocuments the requirement;tests/test_payload.pycovers the four cases.pytest5 passed,flake8clean.Not touched, but worth a look separately:
cc/bccgo into the payload as plain address strings where the API documents[{"email": ..., "name": ...}]objects.🤖 Generated with Claude Code
https://claude.ai/code/session_012EQ7nV1HE5GJjQ3JTP4hQ6
Generated by Claude Code