Skip to content

test: 닉네임 시작/끝 숫자 허용 스펙에 맞게 NicknameValidatorTest 기대값 수정 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pooreumjung merged 2 commits into from
Jul 5, 2026
Merged

test: 닉네임 시작/끝 숫자 허용 스펙에 맞게 NicknameValidatorTest 기대값 수정 #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e1ff7
test: 닉네임 시작/끝 숫자 허용 스펙에 맞게 NicknameValidatorTest 기대값 수정
pooreumjung Jul 4, 2026
ddbfc67
style: 코드 리뷰 반영 - 테스트 메서드명 영문화 및 given/when/then 주석 추가
pooreumjung Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/test/java/ssu/eatssu/domain/user/util/NicknameValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ class NicknameValidatorTest {
}

@ParameterizedTest
@ValueSource(strings = {"유효한 닉네임","available nic","가능한-닉네임","유-효-한-닉-네-임","유 효 한 닉 1 2 a","ㅇㅅㅎㅇㅌ"})
void 유효한_이름을_입력하면_예외가_발생하지_않는다(String input) {
@ValueSource(strings = {"유효한 닉네임","available nic","가능한-닉네임","유-효-한-닉-네-임","유 효 한 닉 1 2 a","ㅇㅅㅎㅇㅌ","0이름","0test","이름0","test0"})
Comment thread
pooreumjung marked this conversation as resolved.
void doesNotThrowWhenNicknameIsValid(String input) {
// given: parameterized valid nickname input

// when & then
assertDoesNotThrow(()-> nicknameValidator.validateNickname(input));
}
Expand Down Expand Up @@ -91,8 +93,10 @@ class NicknameValidatorTest {
}

@ParameterizedTest
@ValueSource(strings = {"0이름","0test","-test"," test"})
void 한글_또는_영어로_시작하지_않는_닉네임인_경우_예외가_발생한다(String input) {
@ValueSource(strings = {"-test"," test"})
Comment thread
pooreumjung marked this conversation as resolved.
void throwsExceptionWhenNicknameStartsWithInvalidCharacter(String input) {
// given: parameterized nickname starting with a symbol (숫자는 시작 문자로 허용됨)

// when & then
assertThatThrownBy(()->nicknameValidator.validateNickname(input))
.isInstanceOf(BaseException.class)
Expand All @@ -101,8 +105,10 @@ class NicknameValidatorTest {
}

@ParameterizedTest
@ValueSource(strings = {"이름0","test0","test-","test "})
void 한글_또는_영어로_끝나지_않는_닉네임인_경우_예외가_발생한다(String input) {
@ValueSource(strings = {"test-","test "})
Comment thread
pooreumjung marked this conversation as resolved.
void throwsExceptionWhenNicknameEndsWithInvalidCharacter(String input) {
// given: parameterized nickname ending with a symbol (숫자는 끝 문자로 허용됨)

// when & then
assertThatThrownBy(()->nicknameValidator.validateNickname(input))
.isInstanceOf(BaseException.class)
Expand Down