-
Notifications
You must be signed in to change notification settings - Fork 0
Main & Develop 코드 버전 동기화 #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7b0b6bc
feat: 예외 로직 분리
pooreumjung e2e1ad3
fix: AuthControllerDocs 오류 수정#2
pooreumjung 9e8cb85
Merge pull request #347 from EAT-SSU/fix/#346-apple-login-error
eunseo9311 8ecdb07
fix: Apple 재로그인 시 email 없는 경우 providerId로 기존 유저 조회
eunseo9311 b77bbe7
refactor: getOAuthInfoByPublicKey()의 이메일 없는 경우 로직 개선
pooreumjung b526174
Merge pull request #348 from EAT-SSU/fix/#346-apple-relogin-without-e…
pooreumjung b2b41cd
fix: 메뉴 리뷰 v2 menuLike null 요청을 400으로 처리
HI-JIN2 d496258
fix: 메뉴 리뷰 v2 요청 필수값 검증 추가
HI-JIN2 6734ce2
Update pull request template to remove resolved issue placeholder (#353)
HI-JIN2 9008f40
feat: Partnership에 period_type 컬럼 추가 및 PartnershipInfo에 period_type 추가
pooreumjung b0f0537
feat: V5__add_period_type_to_partnership.sql 추가
pooreumjung 270eb20
refactor: period_type값 REGULAR -> NORMAL 수정
pooreumjung ec58875
Merge pull request #352 from EAT-SSU/fix/npe-reviewv2
eunseo9311 061ff12
Merge pull request #355 from EAT-SSU/feature/#354-add-partnership-per…
eunseo9311 33980a6
[Feat] 다국어 지원 기능 추가 (#358)
pooreumjung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| import lombok.Getter; | ||
| import ssu.eatssu.domain.partnership.entity.Partnership; | ||
| import ssu.eatssu.domain.partnership.entity.PartnershipRestaurant; | ||
| import ssu.eatssu.domain.partnership.entity.PeriodType; | ||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
|
|
@@ -18,6 +19,7 @@ public class PartnershipInfo { | |
| private String description; | ||
| private LocalDate startDate; | ||
| private LocalDate endDate; | ||
| private PeriodType periodType; | ||
|
|
||
| public static PartnershipInfo fromEntity(Partnership partnership, | ||
| PartnershipRestaurant restaurant, | ||
|
|
@@ -27,6 +29,7 @@ public static PartnershipInfo fromEntity(Partnership partnership, | |
| .description(partnership.getDescription()) | ||
| .startDate(partnership.getStartDate()) | ||
| .endDate(partnership.getEndDate()) | ||
| .periodType(partnership.getPeriodType()) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| .collegeName(partnership.getPartnershipCollege() == null && partnership.getPartnershipDepartment() == null | ||
| ? "총학생회" | ||
| : (partnership.getPartnershipCollege() != null ? partnership.getPartnershipCollege() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
src/main/java/ssu/eatssu/domain/partnership/entity/PeriodType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package ssu.eatssu.domain.partnership.entity; | ||
|
|
||
| public enum PeriodType { | ||
| NORMAL, | ||
| FESTIVAL | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Reviewer, 2024-01-01] ExpiredJwtException뿐만 아니라 SignatureException, MalformedJwtException 등 다른 JWT 관련 예외도 처리할 수 있도록 JwtException 및 IllegalArgumentException을 캐치하는 것이 안전합니다.