Add support for card declaration check core callback - #24
Open
DyXel wants to merge 16 commits into
Open
Conversation
Untested. Depends on edo9300/ygopro-core#174 We use the given opcodes to build an SQL query that checks the count of the cards that match the criteria, this query depends on a custom SQL function (`ocg_is_set`) to check setcodes, which is also implemented here.
there's no need to use a "cursor" variable, due the way the parsing works, when recursing, all the emplace calls can just insert at the beginning of the string, and things will work out. As optimization, append the strings reversed, so that the actual string object will only ever increase to the right, avoiding memory moving
DyXel
force-pushed
the
card_declare_callback
branch
from
July 12, 2026 22:15
6d7e832 to
4ac7d25
Compare
Just start reversing after the initial size offset
implement ocg_bxor sqlite function
Don't depend on fmt for formatting the string and store the og stmt string as pointer instead of reference
xor should be well defined on signed integer types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested. Depends on edo9300/ygopro-core#174
We use the given opcodes to build an SQL query that checks the count of the
cards that match the criteria, this query depends on a custom SQL function
(
ocg_is_set) to check setcodes, which is also implemented here.