fix: rank XP auth bypass and economy balance inflation - #150
Closed
cursor[bot] wants to merge 2 commits into
Closed
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Any member could run /rank reset or /rank set on other users, wiping or inflating XP. Gate these subcommands on ManageGuild to match other admin commands hardened in #130. Co-authored-by: Daan Vrieling <contact@zvapor.xyz>
Concurrent deposit/withdraw requests could drive wallet or bank negative; Math.abs then coerced the deficit into free money. Fail closed when the post-update balance would be negative. Co-authored-by: Daan Vrieling <contact@zvapor.xyz>
zVapor-Dev
marked this pull request as ready for review
September 16, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Critical bug inspection found two high-severity issues on
main(missed during #130 security hardening):1.
/rank resetand/rank setauth bypassresetandsetsubcommands had no permission gate while moderation commands were hardened in Security hardening: permission gates, eval sandbox, single interaction path #130.ManageGuildbefore executing reset/set.2. Economy money inflation via
Math.abs/depositor/withdrawrequests could create money from nothing.Math.abs()coerced the deficit into a positive balance.Math.absand fail closed when post-update balances would be negative.Validation
npm test— 53/53 passingtests/rank-admin-gate.test.js,tests/economy-balance-guard.test.jsNotes