fix(push): wire SW FCM_TOKEN_REFRESH relay and harden lifecycle - #934
Merged
llinsss merged 1 commit intoAug 28, 2026
Merged
Conversation
- Add window message listener for FCM_TOKEN_REFRESH posted by the service worker so token rotation works through both channels: a. Firebase SDK onTokenRefresh (existing) b. SW postMessage relay (new) - Add messagingRef to hold the active Messaging instance; cleared by unsubscribe() and unmount so the SW listener is a no-op when idle - Add userIdRef / vapidKeyRef so fetchAndRegisterToken has zero useCallback deps (no stale closures, no unnecessary re-subscriptions) - unsubscribe() clears messagingRef to prevent orphaned token rotations after logout Tests (24 total, all passing): - Add 5 gap tests: SW relay rotation, SW listener removed on unmount, requestPermission when already granted, unsubscribe with null userId, deleteToken failure does not swallow removeDeviceToken - Fix loading-state test to wrap requestPermission() in act(), removing three React act() warnings Docs: update push-notifications.md with dual-channel rotation diagram, new behaviour-guarantee rows, security note for message listener, and contributor guidance on messagingRef
|
@neymer2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests (24 total, all passing):
Docs: update push-notifications.md with dual-channel rotation diagram, new behaviour-guarantee rows, security note for message listener, and contributor guidance on messagingRef
closes #869