feat: validate multisig thresholds and signer uniqueness - #932
Merged
llinsss merged 1 commit intoAug 28, 2026
Conversation
- Extract validation logic into reusable multisigValidation.ts utility - Add duplicate signer detection (within new signers and vs existing on-chain signers) - Add threshold vs total weight validation to prevent locked accounts - Add warnings for risky configurations (thresholds equal to total weight) - Replace alert() with inline validation error/warning UI - Add confirmation dialog showing exact resulting configuration before signing - Add keyboard-accessible per-signer error messages with aria attributes - Add comprehensive test suites: 37 validation unit tests + 26 component tests Closes DogStark#861
|
@Enemuo-debug Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #861
Summary
This PR adds comprehensive validation for multisig threshold configuration and signer uniqueness to prevent account lockouts and authorization weaknesses.
Changes
New files:
src/utils/multisigValidation.ts— Extracted, reusable validation logic with typed error/warning resultssrc/utils/multisigValidation.test.ts— 37 unit tests covering all validation rulessrc/components/Wallet/MultiSigSetup.test.tsx— 26 component tests for UI behaviorModified:
src/components/Wallet/MultiSigSetup.tsx— Enhanced with inline validation, confirmation dialog, and accessibility improvementsWhat was missing (now fixed)
alert()with accessible inline error/warning panelsAcceptance criteria coverage