to prevent N163's DC drifting error - #423
Closed
Nemo55aa wants to merge 4 commits into
Closed
Conversation
Gumball2415
reviewed
Aug 2, 2026
Collaborator
There was a problem hiding this comment.
I personally am against this change, as DC offsets must be preserved until the final global filter.
Contributor
Author
There was a problem hiding this comment.
Okay! Should we consider just rounding errors ?
Is this N163 instrument waveform is count as just way-rare case ?
if even the DC offset is part of emulation, somewhere somehow dn-fami detects DC offsets and let user know that might be helpful.
This reverts commit 5103050.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix :N163 loses volume during playback and goes silent (by DC drift).
Before this change:
N163 loses volume during playback and goes silent.
Even if any volume column or note-stop placed.
Sample module :
samples_#423.zip
Main reason is N163's blip_buffer update.
Since Blip_buffer is buffer of delta (not a buffer of each sample of amplitude), Those should telescopes with zero error.
After this change :
Blip_buffer has rounding error feedback.
This bounds the accumulated error to below 1 LSB forever.
Hardening fo DC offset :
For hardening, i added dc cutoff to N163 channel. With this, even if without this feedback N163 cuts off DC drift.
Changes: