Skip to content

STAB-FE-003 — Restore the Post-Wave-9 Frontend CI Baseline #558

Description

@dDevAhmed

Problem context

At main commit 5762d37048601ee8084ea111c00fafece181910e, only the issue-inventory workflow runs. The primary CI YAML repeats the top-level permissions key, so lint, test, accessibility, artifact, build and E2E evidence is absent.

Technical scope

  • Make the workflow valid and add a workflow-syntax regression check.
  • Align the Node/package-manager/toolchain with packageManager.
  • Restore artifact, lint, typecheck, unit/integration, accessibility, production build and E2E jobs.
  • Remove duplicate package script keys and hidden skips.
  • Retain fail-closed WalletConnect/config preflight without exposing secrets.

Required tests

All frontend gates at one head SHA plus workflow validation.

Acceptance criteria

  • Complete CI runs on PRs and main.
  • Every required job is green at the same SHA.
  • Missing required secret/config yields an explicit blocked result.
  • Branch protection can require stable check names.

Dependencies

None. Gate B prerequisite for #552–#557.

Non-goals

UI redesign or wallet/API feature work.

Deliverables

Repaired workflow/tooling and evidence.

Complexity and points

  • Complexity: High
  • Points: 200

Activity

  1. dDevAhmed commented on Oct 7, 2026

    @dDevAhmed
    ContributorAuthor

    Gate B verification update (2026-10-07): promotion PR #567 exposed and repaired the merged lockfile inconsistency that left 39 dependency entries on TypeScript 7.0.2 while the repository is pinned to 6.0.3 (head d98b9a40e773a7ab288859844ca2271e0c10bd9a). pnpm install --frozen-lockfile now succeeds.

    The same exact-head run now reaches the underlying baseline and reports:

    • ESLint failure loading react/display-name under ESLint 10 (contextOrFilename.getFilename is not a function).
    • Accessibility regressions in the canonical transaction announcement, mobile workflow config, claims-list states, and ErrorBoundary (redactError is not defined).

    Existing backlog overlap: #565 covers transaction-state convergence; #564 covers ActiveClaimsTable ownership. The remaining failures stay tracked under this Gate B issue because its acceptance criterion requires every frontend job green at one SHA. No Stellar Wave label has been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions