Skip to content

Lightweight module system setup for shared code - #18

Open
dfcowell wants to merge 2 commits into
Devographics:mainfrom
dfcowell:lightweight-repackage
Open

Lightweight module system setup for shared code#18
dfcowell wants to merge 2 commits into
Devographics:mainfrom
dfcowell:lightweight-repackage

Conversation

@dfcowell

@dfcowell dfcowell commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

This PR takes a very light touch to introducing yarn workspaces v1 and a shared module in the "common" directory.

Basically the same as my last PR (#17) except it doesn't completely rearrange the project directories.

This PR takes a very light touch to introducing yarn workspaces v1
and a shared module in the "common" directory.
@netlify

netlify Bot commented Dec 5, 2021

Copy link
Copy Markdown

❌ Deploy Preview for stateofcss2021 failed.

🔨 Explore the source changes: 645945d

🔍 Inspect the deploy log: https://app.netlify.com/sites/stateofcss2021/deploys/61ac30c2f704ed0008462dc4

@dfcowell

dfcowell commented Dec 5, 2021

Copy link
Copy Markdown
Contributor Author

Just a couple of comments on this one.

  1. Workspaces hoists the yarn.lock file into the root directory and it contains all dependencies for all packages in the workspace, that's why the existing lockfiles were removed.
  2. I shuffled some small bits of shared config around into the root directory.

@b3nk3 b3nk3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very neat approach. Clear and concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants