ci: pin pnpm to 10.11.0 (fixes CI crash on Node 20)#322
Open
AminDhouib wants to merge 1 commit into
Open
Conversation
CI's "Setup PNPM environment" steps ran `npm install -g pnpm@latest`, which now resolves to pnpm 11 (requires Node >= 22.13). CI pins Node 20.18.2 via .nvmrc, so pnpm 11 crashes with `ERR_UNKNOWN_BUILTIN_MODULE: node:sqlite` during setup, before any job's real step runs. This fails every PR's checks (Prettier Check, and by extension Status Check) with an error unrelated to the change under review. Pin pnpm to 10.11.0 — the repo's own declared `packageManager` — at all four setup steps in main.yml. .nvmrc (Node 20) is intentionally left unchanged to keep the runtime blast radius minimal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All CI checks currently fail during the "Setup PNPM environment" step, before any job's real work runs:
pnpm@latestbumped to v11, which requires Node ≥ 22.13, but CI pins Node 20.18.2 via.nvmrc. pnpm 11 doesrequire('node:sqlite')(only in Node ≥ 22) → crash. This is time-based drift and breaks every PR's checks (Prettier Check → Status Check) with an error unrelated to the diff under review.Fix
Pin the workflow's pnpm to
10.11.0— the repo's own declaredpackageManager(rootpackage.json) — at all 4 setup steps in.github/workflows/main.yml(npm install -g pnpm@latest→npm install -g pnpm@10.11.0)..nvmrc(Node 20) intentionally left unchanged to keep runtime blast radius minimal.pnpm@latest(checkedpublish.yml/e2e.yml/nightly.yml).Verify
grepofmain.ymlafter the change:pnpm@latest= 0,pnpm@10.11.0= 4 (lines 26/60/138/190). Locally,pnpm@10.11.0(the repo's pinned version) runs CI scripts fine on Node 20 (pnpm run prettier-check→ exit 0).Do not merge yet.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
🤖 Generated with Claude Code