Scheduler: refactor core files (TS) - Part 1#33826
Merged
bit-byte0 merged 5 commits intoJun 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors DevExtreme Scheduler internal core modules to support stricter TS/ESLint rules by renaming m_classes.ts → classes.ts and m_loading.ts → loading.ts, converting the loading helper from Deferred to native Promise, and updating import paths and call sites accordingly.
Changes:
- Introduced new
__internal/scheduler/classes.tsand updated Scheduler/Workspace/Appointment modules to import CSS class constants from it. - Replaced
__internal/scheduler/m_loading.tswith__internal/scheduler/loading.tsusing native Promises and stronger types, and updated consumers/tests. - Updated a few call sites to pass DOM elements (
.get(0)) and to attach rejection handlers (.catch(noop)) where needed.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/loading.tests.js | Updates test import path and adjusts async expectations for the Promise-based loading helper. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts | Switches class-constant imports to ../classes. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts | Switches HEADER_CURRENT_TIME_CELL_CLASS import to ../classes. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_vertical.ts | Switches grouped-strategy class imports to ../classes. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_horizontal.ts | Switches grouped-strategy class imports to ../classes. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline.ts | Switches timeline workspace class imports to ../classes. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_agenda.ts | Switches agenda workspace class imports to ../classes. |
| packages/devextreme/js/__internal/scheduler/r1/utils/base.ts | Switches VERTICAL_GROUP_COUNT_CLASSES import to ../../classes. |
| packages/devextreme/js/__internal/scheduler/m_scheduler.ts | Updates loading helper import and adjusts showLoading options to pass DOM elements. |
| packages/devextreme/js/__internal/scheduler/m_loading.ts | Removes legacy Deferred-based loading helper implementation. |
| packages/devextreme/js/__internal/scheduler/loading.ts | Adds Promise-based, typed loading helper replacing m_loading.ts. |
| packages/devextreme/js/__internal/scheduler/classes.ts | Adds renamed/exported Scheduler class-name constants (replacement for m_classes.ts). |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointment_layout.ts | Switches appointment layout class imports to ../classes. |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointment_collection.ts | Switches appointment collection class imports to ../classes and adjusts import ordering. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/m_appointment.ts | Switches appointment class imports to ../../classes. |
| packages/devextreme/js/__internal/scheduler/appointments/appointment/agenda_appointment.ts | Switches agenda appointment class imports to ../../classes. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/popup.ts | Updates loading helper import, adjusts container to DOM element, and handles Promise rejections. |
aleksei-semikozov
previously approved these changes
Jun 4, 2026
sjbur
previously approved these changes
Jun 4, 2026
aleksei-semikozov
previously approved these changes
Jun 4, 2026
4a74bc6 to
4fce925
Compare
aleksei-semikozov
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rename
m_classes.tsandm_loading.tsto enable strict TS/ESLint rules, add proper types to loading moduleHow
replace
Deferredwith nativePromise, type all params/returns, fix call sites with.get(0)and.catch(noop), update ~14 import paths