DataGrid - AI Assistant: regenerate e2e tests#33808
Open
Alyar666 wants to merge 4 commits into
Open
Conversation
the Regenerate button — visibility after pre-execution failures, absence after command execution, resend-and-replace behavior and in-flight disabling (plan §1.12, §3.8.2) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/extends the DataGrid AI Assistant (chat) TestCafe page models and introduces a new e2e suite covering Regenerate-button behavior across failure/success/abort scenarios, as part of splitting the AI Assistant e2e coverage into per-area PRs.
Changes:
- Added a new
regenerate.functional.tsTestCafe suite validating Regenerate visibility, replacement behavior, and in-flight state handling. - Extended
devextreme-testcafe-modelsDataGrid/AI Assistant chat POMs with additional selectors/accessors (messages, input, suggestions, abort-confirm dialog). - Introduced shared ai-assistant test helpers (
testHelpers.ts) for common constants and client-side utilities.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/testcafe-models/dataGrid/index.ts | Adds DataGrid POM API helper for reading datasource sort and a helper to focus the AI Assistant button. |
| packages/testcafe-models/dataGrid/aiAssistantChat.ts | Expands AI Assistant chat POM to expose input, message grouping, suggestions, and abort-confirm dialog accessors. |
| packages/testcafe-models/chat.ts | Adds a reusable getMessageBubbles() accessor and reuses it in getMessage(). |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/testHelpers.ts | Adds shared constants and ClientFunctions for AI-assistant DataGrid tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/regenerate.functional.ts | New e2e tests for DataGrid AI Assistant Regenerate scenarios and sequential regeneration behavior. |
Add grid-state assertions (apiColumnOption) to every regenerate test so each case confirms whether the command applied or not, and verify 1.12.8 resends the same prompt with a freshly-built context. Switch 1.12.4 to getErrorMessages for consistency. Move the mock factory into the test file and drop POM/testHelpers members unused by this PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Alyar666
force-pushed
the
ai_assistant_e2e_regenerate_26_1
branch
from
73b42b7 to
e092d3d
Compare
added 2 commits
June 5, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR change?
Adds e2e TestCafe tests for the DataGrid AI Assistant — the Regenerate button — visibility after pre-execution failures, absence after command execution, resend-and-replace behavior and in-flight disabling (plan §1.12, §3.8.2).
Part of splitting the AI Assistant e2e suite into per-area pull requests.
How did you achieve this?
aiAssistant.aiIntegration.sendRequestis mocked to return deterministic responses; assertions check chat status and grid state via POM accessors. The PR also includes the sharedtestHelpers.tsand AI Assistanttestcafe-modelsPOM accessors the suite depends on.How can we verify these changes?