Skip to content

fix: make openFeatureProvider an instance field instead of static #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathannorris merged 3 commits into from
Jan 19, 2026
Merged

fix: make openFeatureProvider an instance field instead of static #187

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4b668c
fix: make openFeatureProvider an instance field instead of static
jonathannorris Jan 19, 2026
fd47d40
fix: add thread-safe lazy initialization for openFeatureProvider
jonathannorris Jan 19, 2026
95b1f2c
refactor: simplify getOpenFeatureProvider synchronization
jonathannorris Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/main/java/com/devcycle/sdk/server/local/api/DevCycleLocalClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,21 +325,17 @@ public void clearHooks() {
this.evalHooksRunner.clearHooks();
}

private static DevCycleProvider openFeatureProvider = null;
private DevCycleProvider openFeatureProvider = null;

/**
* @return the OpenFeature provider for this client.
*/
@Override
public FeatureProvider getOpenFeatureProvider() {
if (openFeatureProvider == null) {
synchronized (DevCycleLocalClient.class) {
if (openFeatureProvider == null) {
openFeatureProvider = new DevCycleProvider(this);
}
PlatformData platformData = PlatformData.builder().sdkPlatform("java-of").build();
localBucketing.setPlatformData(platformData.toString());
}
openFeatureProvider = new DevCycleProvider(this);
PlatformData platformData = PlatformData.builder().sdkPlatform("java-of").build();
localBucketing.setPlatformData(platformData.toString());
}
Comment thread
jonathannorris marked this conversation as resolved.
return openFeatureProvider;
}
Expand Down
Loading