Skip to content

fix: saucerswap-v1 broken since api.saucerswap.finance went key-only#2795

Open
0xshubhs wants to merge 1 commit into
DefiLlama:masterfrom
0xshubhs:fix/saucerswap-v1-auth
Open

fix: saucerswap-v1 broken since api.saucerswap.finance went key-only#2795
0xshubhs wants to merge 1 commit into
DefiLlama:masterfrom
0xshubhs:fix/saucerswap-v1-auth

Conversation

@0xshubhs

@0xshubhs 0xshubhs commented Jul 8, 2026

Copy link
Copy Markdown

saucerswap-v1 has been dead and excluded because api.saucerswap.finance now returns 401 Unauthorized on every endpoint the adapter uses (/farms, /pools, /pools/5day-avg) — they made the API key-only. The protocol itself is fine (~$8.7M TVL on Hedera, 22 V1 farms still have live SAUCE emissions).

The endpoints work unchanged with an x-api-key header and the response shapes are identical, so this just threads SAUCERSWAP_API_KEY through the three getData calls, wires it into env.js/serverless.yml like the other keys, and removes the exclusion entry.

You already have a working key for this — dimension-adapters ships SAUCERSWAP_API_KEY in helpers/env.ts, and I ran the harness with that same key: 516/516 tests, 73 pools with sane values (SAUCE-HBAR $1.14M @ 0.47% base + 5.81% reward, USDC-HBAR $552k @ 4.60% + 3.90%, etc). It just needs to be present in this repo's deployment env too.

CI bot run will fail with 401 since the fork doesn't have the key — same situation as the Allium-based adapters in dimension-adapters.

Copilot AI review requested due to automatic review settings July 8, 2026 19:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@0xshubhs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c98baf0-1b94-4ed9-84cb-554043d04530

📥 Commits

Reviewing files that changed from the base of the PR and between 6719a9c and 674624e.

📒 Files selected for processing (4)
  • env.js
  • serverless.yml
  • src/adaptors/saucerswap-v1/index.js
  • src/utils/exclude.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0xshubhs

0xshubhs commented Jul 8, 2026

Copy link
Copy Markdown
Author

The failing test is the expected 401 — the CI run doesn't have SAUCERSWAP_API_KEY (fork PRs don't get secrets). With the key set it's 516/516 tests and 73 pools; the key from dimension-adapters helpers/env.ts works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants