unexclude amnis-finance, the apy fix it was waiting on is in#2793
Open
0xshubhs wants to merge 1 commit into
Open
unexclude amnis-finance, the apy fix it was waiting on is in#27930xshubhs wants to merge 1 commit into
0xshubhs wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the hardcoded exclusion entry for the amnis-finance protocol (id 3667) from the excludedProtocols array in src/utils/exclude.js, which affects the derived excludeAdaptors list. ChangesExclusion list update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amnis-finance was excluded in e5d514d with the note "temp only, until fix is in", and the fix landed the same day (826131c, amnis finance fix apy) — but the exclusion entry was never lifted, so the adapter still exports 0 pools while the protocol sits at ~$4.1M TVL on Aptos.
No adapter changes needed, just removes the exclusion entry.
Local run: 13/13 tests, 1 pool — stAPT $3.46M @ 2.51% apyBase, which lines up with api.amnis.finance/api/v1/stake/info (apr 2.51) and the on-chain stAPT supply × pricePerShare.
Summary by CodeRabbit