Skip to content

Avoid deprecated utcnow for AWS timestamps - #72

Draft
Mirochill wants to merge 1 commit into
DavidMuller:masterfrom
Mirochill:fix-71-utcnow-deprecation
Draft

Mirochill wants to merge 1 commit into
DavidMuller:masterfrom
Mirochill:fix-71-utcnow-deprecation

Conversation

@Mirochill

Copy link
Copy Markdown

Fixes #71.

Summary

  • use datetime.datetime.now(datetime.timezone.utc) when creating AWS Signature V4 timestamps
  • keep a fallback for older Python versions that do not expose datetime.timezone
  • update the time mocks in the existing signing tests so the expected signatures remain fixed

Validation

  • git diff --check
  • Not run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datetime.utcnow() is deprecated

1 participant