fix(sql): bound dollar-quote recursion depth in obfuscator#1965
Draft
paullegranddc wants to merge 1 commit into
Draft
fix(sql): bound dollar-quote recursion depth in obfuscator#1965paullegranddc wants to merge 1 commit into
paullegranddc wants to merge 1 commit into
Conversation
Contributor
📚 Documentation Check Results📦
|
Signed-off-by: paullegranddc <paul.legranddescloizeaux@datadoghq.com>
paullegranddc
force-pushed
the
codex/propose-fix-for-unbounded-sql-recursion
branch
from
7e47461 to
07771bc
Compare
Contributor
🔒 Cargo Deny Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 07771bc | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
- Coverage 72.63% 72.58% -0.05%
==========================================
Files 448 448
Lines 73582 73626 +44
==========================================
- Hits 53444 53441 -3
- Misses 20138 20185 +47
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
obfuscate_sqlon inner dollar-quoted bodies with no depth limit.Description
MAX_DOLLAR_QUOTE_RECURSION_DEPTHand trackrecursion_depthinTokenizerto bound nested processing.obfuscate_sql_with_recursion_limit(...)which returns a safe placeholder ("?") when the depth limit is reached.obfuscate_sql(...)calls for dollar-quoted inner content with calls toobfuscate_sql_with_recursion_limit(..., recursion_depth + 1).Tokenizer::new(...)signature and test call sites and add a regression testtest_dollar_quoted_recursion_depth_is_boundedthat constructs deep nested dollar-quoted SQL and validates the obfuscator completes without crashing.Testing
cargo test -p libdd-trace-obfuscation test_dollar_quoted_recursion_depth_is_boundedand the test passed.cargo test -p libdd-trace-obfuscation dollar_quotedand the suite passed (9 passed; 0 failed).Codex Task