Repository navigation
Explain when the SQL Server rate-limit test bound can go back to +1 - #25872
Conversation
b48888d to
d6ce735
Compare
d6ce735 to
036d4d6
Compare
✅ Dispatcher tests: passed
✅ 46 passed · nothing failed Batches · ✅ batch-01 46/46 Dispatcher finished on |
evalya-impact-summaryEvalya CI impact |
🎉 All green!🧪 All tests passed 🔗 Commit SHA: fa78a68 | Docs | View more details | Give us feedback! |
98841c3 to
a2b715d
Compare
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
The seven .changed changelog fragments cause the release tooling to select major version bumps for this dependency bug fix. Renaming them to .fixed avoids unintended major releases.
🤖 Bits Code Review · Commit a2b715d
a2b715d to
fa78a68
Compare
Review from eric-weaver is dismissed. Related teams and files:
- database-monitoring-agent
- sqlserver/tests/test_activity.py
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Validation ReportAll 22 validations passed. Show details
|
What does this PR do?
Rewrites the comment on the SQL Server
test_activity_collection_rate_limitupper bound. It now says why the bound is+ 2and when it can go back to+ 1. No code or behavior changes.Motivation
#25829 raised the bound to
+ 2becausedatadog-checks-baseran the first two collections of every DBM async job back to back. #25855 fixed that indatadog-checks-base38.9.1. We decided not to raise the minimum base version of the DBM integrations: they pick up the fix with the Agent's base, and a higher minimum would stop customers on older Agents from installing them. So the SQL Server minimum-base-package jobs still test with 38.3.2, which runs the burst, and the bound has to stay at+ 2for now. The old comment described the burst as if it still happened on current base versions.Tests only, so there's no changelog entry.
Checklist before requesting review