Skip to content

Explain when the SQL Server rate-limit test bound can go back to +1 - #25872

Merged
AAraKKe merged 1 commit into
masterfrom
aarakke/dbm-min-base-38.9.1
Oct 30, 2026
Merged

AAraKKe merged 1 commit into
masterfrom
aarakke/dbm-min-base-38.9.1

Conversation

@AAraKKe

@AAraKKe AAraKKe commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Rewrites the comment on the SQL Server test_activity_collection_rate_limit upper bound. It now says why the bound is + 2 and when it can go back to + 1. No code or behavior changes.

Motivation

#25829 raised the bound to + 2 because datadog-checks-base ran the first two collections of every DBM async job back to back. #25855 fixed that in datadog-checks-base 38.9.1. We decided not to raise the minimum base version of the DBM integrations: they pick up the fix with the Agent's base, and a higher minimum would stop customers on older Agents from installing them. So the SQL Server minimum-base-package jobs still test with 38.3.2, which runs the burst, and the bound has to stay at + 2 for now. The old comment described the burst as if it still happened on current base versions.

Tests only, so there's no changelog entry.

Checklist before requesting review

  • I self-reviewed the full diff, and this description matches the final change
  • Tests cover the change, or this description explains why none are needed
  • Automated review comments, including Codex review, were addressed or answered
  • I, the human author, understand this change, can explain it to reviewers, and believe it meets the repository standards

@dd-octo-sts

dd-octo-sts Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

  46/46 jobs

✅ 46 passed · nothing failed

Batches · ✅ batch-01 46/46

Dispatcher finished on a719cb1 — GitHub Run · Dispatcher Logs.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

Evalya CI impact

Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   4 (always emitted)
Changed files:   0

Full impact report
Learn more about CI impact filtering

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fa78a68 | Docs | View more details | Give us feedback!

@AAraKKe
AAraKKe force-pushed the aarakke/dbm-min-base-38.9.1 branch 2 times, most recently from 98841c3 to a2b715d Compare October 30, 2026 15:24
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@AAraKKe
AAraKKe marked this pull request as ready for review October 30, 2026 15:25
@AAraKKe
AAraKKe requested review from a team as code owners October 30, 2026 15:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T16:13:40.709405Z fa78a68 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The seven .changed changelog fragments cause the release tooling to select major version bumps for this dependency bug fix. Renaming them to .fixed avoids unintended major releases.

Open Bits AI session

🤖 Bits Code Review · Commit a2b715d

Comment thread clickhouse/changelog.d/25872.changed Resolved
eric-weaver
eric-weaver previously approved these changes Oct 30, 2026
@AAraKKe
AAraKKe force-pushed the aarakke/dbm-min-base-38.9.1 branch from a2b715d to fa78a68 Compare October 30, 2026 16:10
@temporal-github-worker-1
temporal-github-worker-1 Bot dismissed eric-weaver’s stale review October 30, 2026 16:10

Review from eric-weaver is dismissed. Related teams and files:

  • database-monitoring-agent
    • sqlserver/tests/test_activity.py
@AAraKKe AAraKKe changed the title Bump the minimum base check version to 38.9.1 for DBM integrations Explain when the SQL Server rate-limit test bound can go back to +1 Oct 30, 2026
@AAraKKe

AAraKKe commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: fa78a68ea3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-octo-sts

dd-octo-sts Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 22 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata, naming, and wheel contents ✅
pr-description Validate the pull request checklist and visible description length ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@AAraKKe
AAraKKe added this pull request to the merge queue Oct 30, 2026
Merged via the queue into master with commit 02d8921 Oct 30, 2026
94 of 103 checks passed
@AAraKKe
AAraKKe deleted the aarakke/dbm-min-base-38.9.1 branch October 30, 2026 16:25
@dd-octo-sts dd-octo-sts Bot added this to the 7.87.0 milestone Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants