[madisonmussari]

Motivation

The DBM query benchmarker seeds synthetic data from these statistics so benchmarked plans match the customer's. Postgres already provides them; this adds SQL Server. Per review, the integration sends raw SQL Server statistics: ddoghq/dd-go#26427 passes them through intake (must deploy first, or the fields are dropped), and ddoghq/dd-source#144127 derives the benchmarker's fields. Customer setup docs for the procedure follow in a separate docs PR.

What does this PR do?

Adds opt-in SQL Server column statistics collection (collect_column_statistics, off by default, requires dbm: true and SQL Server 2017+).

• Runs inside the existing metadata job, like PostgresColumnStatisticsCollector in PostgresMetadata, on its own interval (hourly by default). The metadata job now runs when settings or column statistics are enabled, and skips settings when they're off.
• Collects from the online, accessible user databases among get_databases(), calling EXEC datadog.column_statistics @max_tables = ? (default 500 tables per database) with a 60s query timeout, matching the Postgres collector.
• The Agent's login can't read statistics: with the standard DBM grants, sys.dm_db_stats_histogram returns no rows. So, like Postgres's datadog.column_statistics() function, customers install a procedure that runs WITH EXECUTE AS OWNER and returns only statistics, never column values.
• Sends each column's statistics as SQL Server reports them, under SQL Server's names: stats_name, auto_created, user_created, type_name, max_length, is_nullable, is_unique, last_updated (UTC), rows, rows_sampled, steps, modification_counter, average_length (density vector), and histogram with sys.dm_db_stats_histogram's equal_rows, range_rows, distinct_range_rows and average_range_rows per step (never range_high_key). The backend derives what it needs.
• Sent on the existing dbm-column-statistics track with ddsource: sqlserver, one entry per table. Tables are sent as they're read; a table over 900 KB drops its largest histograms, and payloads are split at 4 MB.
• Health events when the procedure is missing, outdated, or the Agent lacks EXECUTE, with recovery once fixed.
• Test setup adds a datadog_test_column_stats database with deterministic data and the procedure (shared tests/sql/column_statistics.sql) to the Linux, Windows and HA environments.

Checklist before requesting review

• I self-reviewed the full diff, and this description matches the final change
• Tests cover the change, or this description explains why none are needed
• Automated review comments, including Codex review, were addressed or answered
• I, the human author, understand this change, can explain it to reviewers, and believe it meets the repository standards

[dd-octo-sts]

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

  46/46 jobs

✅ 46 passed · nothing failed

Batches · ✅ batch-01 46/46

_{Dispatcher finished on 4d85af4 — GitHub Run · Dispatcher Logs.}

[datadog-official]

   

⚠️ Warnings

Your PR has warnings. Please review the issues below.

❄️ 1 New flaky test detected

test_collects_column_statistics from test_column_statistics.py

assert None
 +  where None = <function fullmatch at 0x7ff47043fe20>('\ '2026-10-28T17:26:15Z')
 +    where <function fullmatch at 0x7ff47043fe20> = re.fullmatch

View in Flaky Test Management

ℹ️ Info

No other issues found (see more)

🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 97.08%
• Overall Coverage: 91.66% (+2.10%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 283258b | Docs | View more details | Give us feedback!}

[cit-pr-commenter-54b7da]

evalya-impact-summary

Evalya CI impact

Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   4 (always emitted)
Changed files:   0

Full impact report
Learn more about CI impact filtering

[dd-octo-sts]

Disk usage change

Commit 283258b compared against 9c3b5d6.

Uncompressed

linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
🔺 +19.7 KiB	🔺 +19.7 KiB	🔺 +19.7 KiB	🔺 +19.7 KiB	🔺 +19.7 KiB

Details

Name	Version	Type	linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
sqlserver	23.6.0	Integration	🔺 +19.7 KiB	🔺 +19.7 KiB	🔺 +19.7 KiB	🔺 +19.7 KiB	🔺 +19.7 KiB

Compressed

linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
🔺 +6.04 KiB	🔺 +6.04 KiB	🔺 +6.04 KiB	🔺 +6.04 KiB	🔺 +6.04 KiB

Details

Name	Version	Type	linux-aarch64	linux-x86_64	macos-aarch64	macos-x86_64	windows-x86_64
sqlserver	23.6.0	Integration	🔺 +6.04 KiB	🔺 +6.04 KiB	🔺 +6.04 KiB	🔺 +6.04 KiB	🔺 +6.04 KiB

[linear-code]

DBM-720

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T14:34:36.825335Z	6391c84	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6391c84a67

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[datadog-official]

More details

The completed static review raised no reportable issue in collection, payload mapping, configuration, or async-job integration. Execution against SQL Server remains unverified.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 6391c84}

Review from AAraKKe is dismissed. Related teams and files:

• agent-integrations
  • sqlserver/datadog_checks/sqlserver/column_statistics.py
  • sqlserver/tests/sql/column_statistics.sql
  • sqlserver/tests/test_column_statistics.py

[AAraKKe]

🚀🚀🚀

Review from AAraKKe is dismissed. Related teams and files:

• agent-integrations
  • sqlserver/datadog_checks/sqlserver/column_statistics.py
  • sqlserver/datadog_checks/sqlserver/metadata.py
  • sqlserver/datadog_checks/sqlserver/sqlserver.py
  • sqlserver/tests/test_column_statistics.py

Review from lu-zhengda is dismissed. Related teams and files:

• database-monitoring-agent
  • sqlserver/changelog.d/25769.fixed
  • sqlserver/datadog_checks/sqlserver/column_statistics.py
  • sqlserver/tests/compose-ha/sql/aoag_primary.sql
  • sqlserver/tests/compose-windows/setup.sql
  • sqlserver/tests/compose/setup.sql
  • sqlserver/tests/sql/column_statistics.sql
  • sqlserver/tests/test_column_statistics.py

[dd-octo-sts]

Validation Report

All 22 validations passed.

Show details

Validation	Description	Status
agent-reqs	Verify check versions match the Agent requirements file	✅
ci	Validate CI configuration and code coverage settings	✅
codeowners	Validate every integration has a CODEOWNERS entry	✅
config	Validate default configuration files against spec.yaml	✅
dep	Verify dependency pins are consistent and Agent-compatible	✅
http	Validate integrations use the HTTP wrapper correctly	✅
imports	Validate check imports do not use deprecated modules	✅
integration-style	Validate check code style conventions	✅
jmx-metrics	Validate JMX metrics definition files and config	✅
labeler	Validate PR labeler config matches integration directories	✅
legacy-signature	Validate no integration uses the legacy Agent check signature	✅
license-headers	Validate Python files have proper license headers	✅
licenses	Validate third-party license attribution list	✅
metadata	Validate metadata.csv metric definitions	✅
models	Validate configuration data models match spec.yaml	✅
openmetrics	Validate OpenMetrics integrations disable the metric limit	✅
package	Validate Python package metadata, naming, and wheel contents	✅
pr-description	Validate the pull request checklist and visible description length	✅
qa-label	Validate the pull request declares whether it needs QA for the next Agent release	✅
readmes	Validate README files have required sections	✅
saved-views	Validate saved view JSON file structure and fields	✅
version	Validate version consistency between package and changelog	✅

View full run