fix(CONTP-2001): stop asserting the Operator image tag in baseline tests (datadog chart) - #2907
Open
nlchung wants to merge 9 commits into
Open
fix(CONTP-2001): stop asserting the Operator image tag in baseline tests (datadog chart)#2907nlchung wants to merge 9 commits into
nlchung wants to merge 9 commits into
Conversation
nlchung
force-pushed
the
nlchung/contp-2001-pt2
branch
from
September 8, 2026 14:24
bce273b to
8a87e24
Compare
This comment has been minimized.
This comment has been minimized.
nlchung
force-pushed
the
nlchung/contp-2001-pt2
branch
from
September 9, 2026 14:30
efc4eb0 to
f8a46fb
Compare
nlchung
marked this pull request as ready for review
September 9, 2026 14:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8a46fbb7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nlchung
force-pushed
the
nlchung/contp-2001-pt2
branch
3 times, most recently
from
September 9, 2026 18:13
b9d80f2 to
2bb368c
Compare
nlchung
force-pushed
the
nlchung/contp-2001-pt2
branch
3 times, most recently
from
September 10, 2026 12:42
774e6e8 to
39135cf
Compare
fixup! fixed image tag and corresponding tests
nlchung
force-pushed
the
nlchung/contp-2001-pt2
branch
from
September 10, 2026 13:32
39135cf to
8c1854c
Compare
nlchung
force-pushed
the
nlchung/contp-2001-pt2
branch
from
September 10, 2026 14:46
adc98b1 to
37402f9
Compare
gh-worker-ownership-write-b05516
Bot
removed the request for review
from a team
September 10, 2026 14:46
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
khewonc
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Same problem as #2897, but in the
datadogchart's baseline test — which embedsdatadog-operatoras a subchart, so it wasn't covered by that fix.Test_baseline_inputscompares every rendered resource untyped (rawmap[string]interface{}), and the Operator's own version (image tag, plus theapp.kubernetes.io/versionlabel sourced fromChart.AppVersion) shows up on multiple resource kinds the subchart renders — not just the Deployment — so every Operator release broke this baseline too, for no real reason.app.kubernetes.io/versionlabel before comparing actual vs. baseline, viastripOperatorReleaseVersioninverifyUntypedResources, reusing the existingutils.ImageRepositoryhelper from fix(CONTP-2001): stop asserting the Operator image tag in baseline tests (operator chart) #2897.app.kubernetes.io/name: operator(Deployment, ServiceAccount, ClusterRole, etc.), not just the Deployment — the untyped comparison walks every kind the subchart renders, so a Deployment-only strip (as in fix(CONTP-2001): stop asserting the Operator image tag in baseline tests (operator chart) #2897's typed test) leaves the other kinds still asserting on a version that changes every release.make update-test-baselines-datadog-agentstep fromphase_datadoginscripts/release-operator.sh— the release worker no longer needs to regenerate these baselines on every Operator bump.Verified: bumped the embedded
datadog-operatorsubchart'sappVersionto a throwaway value locally and confirmedTest_baseline_inputspasses with no baseline changes needed across all 51 scenarios; separately confirmed a real structural change (unrelated to version) still fails the same test, so the fix only suppresses version noise, not genuine drift.Which issue this PR fixes
CONTP-2001
Special notes for your reviewer:
Stacked on #2897 — no chart behavior changes, this only touches test assertions and the release script. This PR targets
nicole.chung/contp-2001(notmain), so #2897 needs to merge first; this PR's base will then need to be retargeted tomainbefore it can merge.Checklist
datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)