Skip to content

mikrotik: Modernize record conversion#4563

Open
TomOnTime wants to merge 7 commits into
release_candidate_v5from
mod_mikrotik
Open

mikrotik: Modernize record conversion#4563
TomOnTime wants to merge 7 commits into
release_candidate_v5from
mod_mikrotik

Conversation

@TomOnTime

Copy link
Copy Markdown
Collaborator

Dear @hedger. I could use your help. I'm doing upgrades to the code base and I have no way to test your provider. Please run the integration test and let me know the result. How to run integration tests is here: https://docs.dnscontrol.org/developer-info/integration-tests

Summary

  • build downloaded records with the modern record factories
  • pass the domain config through conversion for modern label handling
  • modernize provider unit-test record setup while preserving custom forwarder behavior

Validation

  • ../../bin/is_modern.sh (Steps 1-7 clean)
  • go test ./providers/mikrotik
  • bin/generate-all.sh
  • go test ./...

@TomOnTime
TomOnTime marked this pull request as ready for review July 24, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants