v0.0.7 [BETA] Hotfix Lace wallet connection (issue #3)#4
Merged
Conversation
…g the CIP-30 API object and surface connection errors that actually mean something. Lace deep-freezes the `window.cardano` API object it exposes to dApps as a security measure, which means setting `wallet.loading = true` from inside `connect()` throws a TypeError before we ever get to `wallet.enable()`. Users just saw the generic "Make sure you have a dApp account selected!" toast and had no way to actually connect. Updates include: - Move per-button loading state off the CIP-30 wallet handle and into a `walletLoading` map on App.vue's data, keyed by `wallet.name`. The mixin's `connect()` no longer writes anything to the wallet object - reads only. - Replace the single hardcoded connect error string with a `describeConnectError` classifier that pattern-matches the frozen-object TypeError Lace throws, the CIP-30 APIError codes (-3 user refused, -1 invalid request), and otherwise surfaces the underlying error message so we can actually see what went wrong next time. - Bump version to 0.0.7 [BETA] in `package.json` and `src/version.json`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop mutating the CIP-30 API object and surface connection errors that actually mean something.
Lace deep-freezes the
window.cardanoAPI object it exposes to dApps as a security measure, which means settingwallet.loading = truefrom insideconnect()throws a TypeError before we ever get towallet.enable(). Users just saw the generic "Make sure you have a dApp account selected!" toast and had no way to actually connect.Updates include:
walletLoadingmap on App.vue's data, keyed bywallet.name. The mixin'sconnect()no longer writes anything to the wallet object - reads only.describeConnectErrorclassifier that pattern-matches the frozen-object TypeError Lace throws, the CIP-30 APIError codes (-3 user refused, -1 invalid request), and otherwise surfaces the underlying error message so we can actually see what went wrong next time.package.jsonandsrc/version.json.