Fix iframe strict mode violation in E2E tests#120
Closed
Conversation
Add overrides to resolve known vulnerabilities: - picomatch@2 -> 2.3.2 (ReDoS via extglob quantifiers) - picomatch@4 -> 4.0.4 (ReDoS via extglob quantifiers) - yaml@1 -> 1.10.3 (stack overflow via deeply nested collections) - brace-expansion@2 -> 2.0.3 (zero-step sequence hang) - lodash -> 4.18.1 (prototype pollution and code injection) Remaining: brace-expansion 1.x (1.1.12) has no fixed version available.
The Falcon console sometimes renders a hidden iframe alongside the app
extension iframe. Using locator('iframe') fails with "strict mode
violation: resolved to 2 elements". Adding .first() targets the visible
iframe and avoids the error.
Contributor
Author
|
Closing - the iframe failure was a one-time transient issue, not a recurring bug. Extension apps have been passing consistently on prior nights. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Falcon console sometimes renders a hidden iframe alongside the app extension iframe, causing Playwright's strict mode to fail with "resolved to 2 elements" when using
locator('iframe'). Adding.first()targets the first (visible) iframe and avoids the error.This was causing nightly E2E test failures in CI.