🎨 Palette: [UX improvement] Add context to generic action buttons in EditEdgeModal - #625
Conversation
…odal
💡 What: Added context-specific aria-label attributes ("관계 삭제", "관계 설정 취소", "관계 저장") to the generic action buttons in the EditEdgeModal.
🎯 Why: Generic button names like "삭제" and "취소" lack sufficient context for screen reader users, especially when multiple modals can appear.
📸 Before/After: Visuals remain unchanged, but screen readers will now announce "관계 삭제" instead of just "삭제".
♿ Accessibility: Improves accessibility by providing meaningful accessible names for destructive and general form actions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Improves accessibility of the relationship editing modal by giving generic action buttons context-specific accessible names, reducing ambiguity for screen reader users and keeping tests aligned with the updated accessible button names.
Changes:
- Added context-specific
aria-labelvalues to Delete/Cancel/Save buttons inEditEdgeModal. - Updated modal coverage tests to query buttons by their new accessible names.
- Documented the accessibility rationale/pattern in the palette notes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/components/modals/EditEdgeModal.tsx | Adds contextual aria-labels to generic modal action buttons (“삭제/취소/저장”). |
| frontend/src/components/modals/ModalCoverage.test.tsx | Updates queries to match the buttons’ new accessible names. |
| .Jules/palette.md | Records the accessibility learning/pattern for future modal work. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head9258437cef51d33b7d88651db3ec0ed662c36871. -
Head SHA:
9258437cef51d33b7d88651db3ec0ed662c36871 -
Workflow run: 30486943715
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: palette.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: palette.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend (2 files)"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend (2 files)"]
R2 --> V2["frontend tests"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: palette.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: palette.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend (2 files)"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend (2 files)"]
R2 --> V2["frontend tests"]
|
Added context-specific aria-label attributes to the generic action buttons in the EditEdgeModal to improve screen reader accessibility. Also updated corresponding tests.
PR created automatically by Jules for task 17155883334527711149 started by @seonghobae