Skip to content

๐ŸŽจ Palette: ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜(Enterํ‚ค ์ œ์ถœ) ์ง€์›์„ ์œ„ํ•œ ํผ ์ž…๋ ฅ๋ถ€ ๊ตฌ์กฐ ๊ฐœ์„  - #584

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-form-submission-ux-15170353202481437681
Closed

๐ŸŽจ Palette: ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜(Enterํ‚ค ์ œ์ถœ) ์ง€์›์„ ์œ„ํ•œ ํผ ์ž…๋ ฅ๋ถ€ ๊ตฌ์กฐ ๊ฐœ์„ #584
seonghobae wants to merge 1 commit into
mainfrom
palette-form-submission-ux-15170353202481437681

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What

  • App.tsx ๋‚ด์˜ ํ”„๋กœ์ ํŠธ ์ƒ์„ฑ(New project), ์ƒˆ ์—ฐ๊ฒฐ ์ถ”๊ฐ€(New connection (DSN)) ์ž…๋ ฅ ํ•„๋“œ๋ฅผ <form> ํƒœ๊ทธ๋กœ ๊ฐ์‹ธ๊ณ  ํผ ์ œ์ถœ ์ด๋ฒคํŠธ(onSubmit)๋ฅผ ํ†ตํ•ด ์ž‘๋™ํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ž…๋ ฅ ํ•„๋“œ์™€ ์—ฐ๊ฒฐ๋œ ๋ฒ„ํŠผ๋“ค์˜ type์„ button์—์„œ submit์œผ๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ œ์ถœ ์‹œ e.preventDefault()๋ฅผ ํ˜ธ์ถœํ•˜์—ฌ ํŽ˜์ด์ง€ ์ƒˆ๋กœ๊ณ ์นจ์„ ๋ฐฉ์ง€ํ•˜๊ณ  ๊ธฐ์กด ๋กœ์ง์ด ์‹คํ–‰๋˜๋„๋ก ๊ตฌ์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why

  • ๊ธฐ์กด ๊ตฌํ˜„์—์„œ๋Š” <div> ๊ธฐ๋ฐ˜ ๋ ˆ์ด์•„์›ƒ์— onClick ํ•ธ๋“ค๋Ÿฌ๋งŒ ์—ฐ๊ฒฐ๋˜์–ด ์žˆ์–ด์„œ ๋งˆ์šฐ์Šค ํด๋ฆญ ์—†์ด ํ‚ค๋ณด๋“œ(Enter ํ‚ค)๋งŒ์œผ๋กœ ํผ ์ œ์ถœ์ด ๋ถˆ๊ฐ€๋Šฅํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ๊ฒฐ์—ฌ)
  • ์‚ฌ์šฉ์ž๊ฐ€ ๋ฐ์ดํ„ฐ ์ž…๋ ฅ ํ›„ ์ฆ‰์‹œ Enter ํ‚ค๋ฅผ ๋ˆŒ๋Ÿฌ ์ƒ์„ฑ ๋™์ž‘์„ ์ˆ˜ํ–‰ํ•  ์ˆ˜ ์žˆ๋„๋ก ํŽธ์˜์„ฑ์„ ๋†’์—ฌ์ฃผ๊ธฐ ์œ„ํ•ด ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After

์™ธ๊ด€์ƒ ์‹œ๊ฐ์  ๋ ˆ์ด์•„์›ƒ(๋””์ž์ธ)์€ ๋™์ผํ•˜๊ฒŒ ์œ ์ง€๋˜๋ฉฐ, ์—”ํ„ฐ ํ‚ค ์ž…๋ ฅ์ด ๊ฐ€๋Šฅํ•ด์ง„ UX์ ์ธ ๋ณ€ํ™”๋งŒ ์กด์žฌํ•ฉ๋‹ˆ๋‹ค. Playwright ํ…Œ์ŠคํŠธ๋ฅผ ํ†ตํ•ด UI๊ฐ€ ํŒŒ๊ดด๋˜์ง€ ์•Š๊ณ  ์ •๊ตํ•˜๊ฒŒ ๋™์ž‘ํ•˜๋Š” ๊ฒƒ์„ ๊ฒ€์ฆํ–ˆ์Šต๋‹ˆ๋‹ค.

โ™ฟ Accessibility

  • form ์š”์†Œ์™€ type="submit" ๋ฒ„ํŠผ์˜ ์‚ฌ์šฉ์œผ๋กœ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์™€ ํ‚ค๋ณด๋“œ ์ „์šฉ ์‚ฌ์šฉ์ž(Accessibility)๊ฐ€ ํผ์˜ ์ œ์ถœ ์˜์—ญ๊ณผ ๋ชฉ์ ์„ ๋” ๋ช…ํ™•ํ•˜๊ฒŒ ํŒŒ์•…ํ•  ์ˆ˜ ์žˆ๋„๋ก ์ปจํ…์ŠคํŠธ๊ฐ€ ํ–ฅ์ƒ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

PR created automatically by Jules for task 15170353202481437681 started by @seonghobae

โ€ฆaccessibility. Specifically, I added form wrappers to the input groups so they now support keyboard confirmation via the Enter key.

Here is a breakdown of what I've done:
- Wrapped the "์ƒˆ ํ”„๋กœ์ ํŠธ" inline input, "New project" sidebar input, and "New connection (DSN)" input in `<form>` elements.
- Changed their corresponding buttons to act as form triggers rather than standard buttons.
- Added event handlers utilizing `e.preventDefault()` to avoid page reloads, which correctly falls back to the original click-handler logic conditionals.
- This ensures that screen reader and keyboard users can seamlessly complete their inputs using the "Enter" key instead of relying purely on a mouse-click for non-modal inputs.

Let me know if you need any further adjustments!
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 0e0c09d82c31e07e05e635a88c9a93ba7cecaed2.

  • Head SHA: 0e0c09d82c31e07e05e635a88c9a93ba7cecaed2

  • Workflow run: 29620016944

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: palette.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: palette.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Frontend: App.tsx"]
  S2 --> I2["browser runtime and bundle"]
  I2 --> R2["Review risk: Frontend: App.tsx"]
  R2 --> V2["frontend tests"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 0e0c09d82c31e07e05e635a88c9a93ba7cecaed2
  • Workflow run: 29620016944
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 0e0c09d82c31e07e05e635a88c9a93ba7cecaed2.

  • Head SHA: 0e0c09d82c31e07e05e635a88c9a93ba7cecaed2

  • Workflow run: 29620016944

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: palette.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: palette.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Frontend: App.tsx"]
  S2 --> I2["browser runtime and bundle"]
  I2 --> R2["Review risk: Frontend: App.tsx"]
  R2 --> V2["frontend tests"]
Loading

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closed as superseded/duplicate Palette a11y PR; keyboard/form a11y baseline already on main (#568/#567/#534). Remaining a11y land via priority PR or follow-up if needed.

@seonghobae seonghobae closed this Jul 31, 2026
@google-labs-jules

Copy link
Copy Markdown

Closed as superseded/duplicate Palette a11y PR; keyboard/form a11y baseline already on main (#568/#567/#534). Remaining a11y land via priority PR or follow-up if needed.

Understood. Acknowledging that this PR is superseded/duplicate and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant