π¨ Palette: λΉλκΈ° μμ λ²νΌμ aria-busy μμ± μΆκ°λ₯Ό ν΅ν μ κ·Όμ± κ°μ #176
π¨ Palette: λΉλκΈ° μμ
λ²νΌμ aria-busy μμ± μΆκ°λ₯Ό ν΅ν μ κ·Όμ± κ°μ #176seonghobae wants to merge 1 commit into
Conversation
β¦λ μμ μ μ±κ³΅μ μΌλ‘ λ§μ³€μ΅λλ€. λΉλκΈ° μμ μ΄ μ§ν μ€μΌ λ μ€ν¬λ¦° 리λ μ¬μ©μμκ² λͺ νν μν νΌλλ°±μ μ 곡ν μ μλλ‘, κ° μ‘μ λ²νΌμ λμ μΌλ‘ `aria-busy="true"` μμ±μ μΆκ°νκ³ μ κ±°νλ λ‘μ§μ ꡬννμ΅λλ€. - **μ μ© λμ**: Details, Retry, Refresh evidence, Load demo story, λ¬Έμ μ μΆ(Document) λ²νΌ - **μμ λ΄μ**: `demo.js` λ‘μ§ μμ λ° μ΄μ κ΄λ ¨λ `ViewerUiControllerTest.java` ν μ€νΈ μ½λ μ λ°μ΄νΈ μμ λ λ΄μ©μ νμΈν΄ 보μκ³ , μΆκ°λ‘ νμνμ μ¬νμ΄λ μμ ν λΆλΆμ΄ μλ€λ©΄ μΈμ λ λ§μν΄ μ£ΌμΈμ!
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: λΉλκΈ° μμ μ μννλ 5κ°μ μ‘μ λ²νΌ(Details, Retry, Refresh evidence, Load demo story, Submit document)μ λν΄ μμ μ§ν μ€
aria-busy="true"μμ±μ΄ μ μ©λλλ‘ λ‘μ§μ μΆκ°νμ΅λλ€.π― Why: κΈ°μ‘΄μλ λΉλκΈ° μμ μ λ²νΌμ΄
disabledμ²λ¦¬λκ³ ν μ€νΈκ° "Loading..." λ±μΌλ‘ λ³κ²½λμμΌλ, μκ° μ₯μ μΈμ΄λ μ€ν¬λ¦° 리λ μ¬μ©μμκ²λ νμ¬ μμκ° μ°μ° μ€μ΄λΌλ μν λ³ν(busy state)λ₯Ό λͺ νν μ λ¬νκΈ° λΆμ‘±νμ΅λλ€.aria-busyμμ±μ ν΅ν΄ 보쑰 κΈ°κΈ°κ° μν λ³νλ₯Ό μ¬λ°λ₯΄κ² μΈμνλλ‘ ν©λλ€.πΈ Before/After: μκ°μ λ λλ§ λ³κ²½μ μμΌλ, λ΄λΆ DOM μμ±μ΄ λμ μΌλ‘ μ μ΄λμ΄ μ κ·Όμ±μ΄ κ°νλμμ΅λλ€. Playwright μ€ν¬λ¦½νΈλ₯Ό ν΅ν΄ μκ° λ° DOM κ²μ¦μ μλ£νμ΅λλ€.
βΏ Accessibility: 보쑰 κΈ°μ μ λΉλκΈ° νΌλλ°± κ°μ (
aria-busyμμ± νμ©).PR created automatically by Jules for task 6357355303477821496 started by @seonghobae