Skip to content

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— aria-busy 속성 μΆ”κ°€λ₯Ό ν†΅ν•œ μ ‘κ·Όμ„± κ°œμ„ #176

Open
seonghobae wants to merge 1 commit into
mainfrom
palette-aria-busy-async-buttons-6357355303477821496
Open

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— aria-busy 속성 μΆ”κ°€λ₯Ό ν†΅ν•œ μ ‘κ·Όμ„± κ°œμ„ #176
seonghobae wants to merge 1 commit into
mainfrom
palette-aria-busy-async-buttons-6357355303477821496

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: 비동기 μž‘μ—…μ„ μˆ˜ν–‰ν•˜λŠ” 5개의 μ•‘μ…˜ λ²„νŠΌ(Details, Retry, Refresh evidence, Load demo story, Submit document)에 λŒ€ν•΄ μž‘μ—… μ§„ν–‰ 쀑 aria-busy="true" 속성이 μ μš©λ˜λ„λ‘ λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: κΈ°μ‘΄μ—λŠ” 비동기 μž‘μ—… μ‹œ λ²„νŠΌμ΄ disabled 처리되고 ν…μŠ€νŠΈκ°€ "Loading..." λ“±μœΌλ‘œ λ³€κ²½λ˜μ—ˆμœΌλ‚˜, μ‹œκ° μž₯μ• μΈμ΄λ‚˜ 슀크린 리더 μ‚¬μš©μžμ—κ²ŒλŠ” ν˜„μž¬ μš”μ†Œκ°€ μ—°μ‚° μ€‘μ΄λΌλŠ” μƒνƒœ λ³€ν™”(busy state)λ₯Ό λͺ…ν™•νžˆ μ „λ‹¬ν•˜κΈ° λΆ€μ‘±ν–ˆμŠ΅λ‹ˆλ‹€. aria-busy 속성을 톡해 보쑰 κΈ°κΈ°κ°€ μƒνƒœ λ³€ν™”λ₯Ό μ˜¬λ°”λ₯΄κ²Œ μΈμ‹ν•˜λ„λ‘ ν•©λ‹ˆλ‹€.
πŸ“Έ Before/After: μ‹œκ°μ  λ Œλ”λ§ 변경은 μ—†μœΌλ‚˜, λ‚΄λΆ€ DOM 속성이 λ™μ μœΌλ‘œ μ œμ–΄λ˜μ–΄ 접근성이 κ°•ν™”λ˜μ—ˆμŠ΅λ‹ˆλ‹€. Playwright 슀크립트λ₯Ό 톡해 μ‹œκ° 및 DOM 검증을 μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€.
β™Ώ Accessibility: 보쑰 기술의 비동기 ν”Όλ“œλ°± κ°œμ„  (aria-busy 속성 ν™œμš©).


PR created automatically by Jules for task 6357355303477821496 started by @seonghobae

β€¦λŠ” μž‘μ—…μ„ μ„±κ³΅μ μœΌλ‘œ λ§ˆμ³€μŠ΅λ‹ˆλ‹€.

비동기 μž‘μ—…μ΄ μ§„ν–‰ 쀑일 λ•Œ 슀크린 리더 μ‚¬μš©μžμ—κ²Œ λͺ…ν™•ν•œ μƒνƒœ ν”Όλ“œλ°±μ„ μ œκ³΅ν•  수 μžˆλ„λ‘, 각 μ•‘μ…˜ λ²„νŠΌμ— λ™μ μœΌλ‘œ `aria-busy="true"` 속성을 μΆ”κ°€ν•˜κ³  μ œκ±°ν•˜λŠ” λ‘œμ§μ„ κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.

- **적용 λŒ€μƒ**: Details, Retry, Refresh evidence, Load demo story, λ¬Έμ„œ 제좜(Document) λ²„νŠΌ
- **μž‘μ—… λ‚΄μ—­**: `demo.js` 둜직 μˆ˜μ • 및 이에 κ΄€λ ¨λœ `ViewerUiControllerTest.java` ν…ŒμŠ€νŠΈ μ½”λ“œ μ—…λ°μ΄νŠΈ

μž‘μ—…λœ λ‚΄μš©μ„ 확인해 λ³΄μ‹œκ³ , μΆ”κ°€λ‘œ ν•„μš”ν•˜μ‹  μ‚¬ν•­μ΄λ‚˜ μˆ˜μ •ν•  뢀뢄이 μžˆλ‹€λ©΄ μ–Έμ œλ“  말씀해 μ£Όμ„Έμš”!
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant