Skip to content

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— λ‘œλ”© μ€‘μž„μ„ μ•Œλ¦¬λŠ” μ ‘κ·Όμ„± 속성 μΆ”κ°€#171

Open
seonghobae wants to merge 1 commit into
mainfrom
fix/async-button-accessibility-7485573444037385444
Open

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— λ‘œλ”© μ€‘μž„μ„ μ•Œλ¦¬λŠ” μ ‘κ·Όμ„± 속성 μΆ”κ°€#171
seonghobae wants to merge 1 commit into
mainfrom
fix/async-button-accessibility-7485573444037385444

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: demo.js 파일 λ‚΄μ˜ λͺ¨λ“  μ£Όμš” 비동기 μž‘μ—… λ²„νŠΌμ— λ‘œλ”© μƒνƒœλ₯Ό λͺ…μ‹œμ μœΌλ‘œ μ•Œλ¦¬κΈ° μœ„ν•΄ aria-busy="true" μ ‘κ·Όμ„± 속성을 λΆ€μ—¬ν•˜κ³  μž‘μ—… μ™„λ£Œ μ‹œ 이λ₯Ό μ œκ±°ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: κΈ°μ‘΄μ—λŠ” λ²„νŠΌμ„ λ‹¨μˆœνžˆ disabled μ²˜λ¦¬ν•˜κ³  ν…μŠ€νŠΈλ§Œ λ³€κ²½ν–ˆμœΌλ‚˜, 슀크린 리더 λ“± 보쑰 κΈ°κΈ°λ₯Ό μ‚¬μš©ν•˜λŠ” μ‚¬μš©μžμ—κ²Œ ν˜„μž¬ λ„€νŠΈμ›Œν¬ μš”μ²­ λ“± λ°±κ·ΈλΌμš΄λ“œ μž‘μ—…μ΄ μ§„ν–‰ μ€‘μ΄λΌλŠ” μƒνƒœκ°€ λͺ…ν™•ν•˜κ²Œ μ „λ‹¬λ˜μ§€ μ•ŠλŠ” μ ‘κ·Όμ„± λ¬Έμ œκ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: μ‹œκ°μ μΈ UI 변경은 μ—†μœΌλ©° μ‹œλ§¨ν‹± 접근성이 κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€. (Playwright 검증 μŠ€ν¬λ¦°μƒ·μœΌλ‘œ λ‘œλ”© μƒνƒœλ₯Ό ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.)
β™Ώ Accessibility: 비동기 λ‘œλ”© μƒνƒœλ₯Ό κ°–λŠ” μ£Όμš” 5개 λ²„νŠΌ(상세보기, μž¬μ‹œλ„, 증거 λ¦¬ν”„λ ˆμ‹œ, 데λͺ¨ 뢈러였기, 제좜)에 aria-busy μƒνƒœκ°€ μ˜¬λ°”λ₯΄κ²Œ μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 7485573444037385444 started by @seonghobae

- `demo.js`의 `renderHistory` (Details λ²„νŠΌ)
- `demo.js`의 `retryActiveJob` (Retry λ²„νŠΌ)
- `demo.js`의 `refreshKpiEvidence` (Refresh λ²„νŠΌ)
- `demo.js`의 `loadDemoData` (Load Demo λ²„νŠΌ)
- `demo.js`의 `submitDocument` (제좜 λ²„νŠΌ)

μž‘μ—… μ‹œμž‘ μ‹œ `aria-busy="true"`λ₯Ό λΆ€μ—¬ν•˜κ³ , μ’…λ£Œ μ‹œ(`finally` 블둝 λ“±) `removeAttribute("aria-busy")`λ₯Ό ν˜ΈμΆœν•˜μ—¬ 슀크린 리더와 같은 보쑰 기기에 비동기 λ‘œλ”© μƒνƒœκ°€ λͺ…ν™•ν•˜κ²Œ μ „λ‹¬λ˜λ„λ‘ μ½”λ“œλ₯Ό κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
- κ΄€λ ¨ 배움을 `.jules/palette.md` νŒŒμΌμ— 잘 기둝해 λ‘μ—ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant