π‘οΈ Sentinel: [HIGH] Fix CPU exhaustion DoS vulnerability in password hashing#283
π‘οΈ Sentinel: [HIGH] Fix CPU exhaustion DoS vulnerability in password hashing#283seonghobae wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: μ¬μ©μ λΉλ°λ²νΈ μ λ ₯κ°μ μ΅λ κΈΈμ΄ μ νμ΄ μμ΄, λ§€μ° κΈ΄ λ¬Έμμ΄μ μ μ‘ν κ²½μ°
bcryptν΄μ± κ³Όμ μμ κ³Όλν CPU μμμ΄ μλͺ¨λλ DoS(μλΉμ€ κ±°λΆ) μ·¨μ½μ μ΄ μ‘΄μ¬νμ΅λλ€.π― Impact: 곡격μκ° μ μμ μΌλ‘ κ±°λν λΉλ°λ²νΈ λ¬Έμμ΄μ νμκ°μ , λ‘κ·ΈμΈ λλ λΉλ°λ²νΈ μ¬μ€μ μλν¬μΈνΈμ μ§μμ μΌλ‘ μ μ‘ν κ²½μ°, μλ²μ CPU μμμ΄ κ³ κ°λμ΄ μ μμ μΈ μλΉμ€ μ κ³΅μ΄ λΆκ°λ₯ν΄μ§ μ μμ΅λλ€.
π§ Fix:
@argos/sharedμLoginRequestSchema,RegisterRequestSchemaλ°@argos/webμResetPasswordSchemaλ΄passwordμpasswordConfirmationνλμ.max(1024)κ²μ¦ λ‘μ§μ μΆκ°νμ¬ μ λ ₯κ°μ ν¬κΈ°λ₯Ό μμ ν μμ€μΌλ‘ μ ννμ΅λλ€.β Verification:
pnpm testλͺ λ Ήμ΄λ₯Ό ν΅ν΄ μΈμ¦ κ΄λ ¨ ν μ€νΈ(μ:auth-flow.test.ts,password-reset-links/route.test.tsλ±)κ° λͺ¨λ μ μμ μΌλ‘ ν΅κ³Όν¨μ νμΈνμ΅λλ€. (No regressions)PR created automatically by Jules for task 7649270578962848066 started by @seonghobae