Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix CPU exhaustion DoS vulnerability in password hashing#283

Open
seonghobae wants to merge 1 commit into
developmentalfrom
sentinel/fix-password-dos-7649270578962848066
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix CPU exhaustion DoS vulnerability in password hashing#283
seonghobae wants to merge 1 commit into
developmentalfrom
sentinel/fix-password-dos-7649270578962848066

Conversation

@seonghobae

Copy link
Copy Markdown

🚨 Severity: HIGH
πŸ’‘ Vulnerability: μ‚¬μš©μž λΉ„λ°€λ²ˆν˜Έ μž…λ ₯값에 μ΅œλŒ€ 길이 μ œν•œμ΄ μ—†μ–΄, 맀우 κΈ΄ λ¬Έμžμ—΄μ„ 전솑할 경우 bcrypt ν•΄μ‹± κ³Όμ •μ—μ„œ κ³Όλ„ν•œ CPU μžμ›μ΄ μ†Œλͺ¨λ˜λŠ” DoS(μ„œλΉ„μŠ€ κ±°λΆ€) 취약점이 μ‘΄μž¬ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Impact: κ³΅κ²©μžκ°€ μ•…μ˜μ μœΌλ‘œ κ±°λŒ€ν•œ λΉ„λ°€λ²ˆν˜Έ λ¬Έμžμ—΄μ„ νšŒμ›κ°€μž…, 둜그인 λ˜λŠ” λΉ„λ°€λ²ˆν˜Έ μž¬μ„€μ • μ—”λ“œν¬μΈνŠΈμ— μ§€μ†μ μœΌλ‘œ 전솑할 경우, μ„œλ²„μ˜ CPU μžμ›μ΄ κ³ κ°ˆλ˜μ–΄ 정상적인 μ„œλΉ„μŠ€ 제곡이 λΆˆκ°€λŠ₯ν•΄μ§ˆ 수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ Fix: @argos/shared의 LoginRequestSchema, RegisterRequestSchema 및 @argos/web의 ResetPasswordSchema λ‚΄ password와 passwordConfirmation ν•„λ“œμ— .max(1024) 검증 λ‘œμ§μ„ μΆ”κ°€ν•˜μ—¬ μž…λ ₯κ°’μ˜ 크기λ₯Ό μ•ˆμ „ν•œ μˆ˜μ€€μœΌλ‘œ μ œν•œν–ˆμŠ΅λ‹ˆλ‹€.
βœ… Verification: pnpm test λͺ…λ Ήμ–΄λ₯Ό 톡해 인증 κ΄€λ ¨ ν…ŒμŠ€νŠΈ(예: auth-flow.test.ts, password-reset-links/route.test.ts λ“±)κ°€ λͺ¨λ‘ μ •μƒμ μœΌλ‘œ 톡과함을 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. (No regressions)


PR created automatically by Jules for task 7649270578962848066 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant