Skip to content

🎨 Palette: [UX improvement] κ΄€λ¦¬μž λŒ€μ‹œλ³΄λ“œ 볡사 ν”Όλ“œλ°± 및 μ ‘κ·Όμ„± κ°œμ„ #281

Open
seonghobae wants to merge 1 commit into
developmentalfrom
palette-admin-ux-improvement-12925237939853966349
Open

🎨 Palette: [UX improvement] κ΄€λ¦¬μž λŒ€μ‹œλ³΄λ“œ 볡사 ν”Όλ“œλ°± 및 μ ‘κ·Όμ„± κ°œμ„ #281
seonghobae wants to merge 1 commit into
developmentalfrom
palette-admin-ux-improvement-12925237939853966349

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What

κ΄€λ¦¬μž λŒ€μ‹œλ³΄λ“œ(admin-dashboard.tsx)의 λΉ„λ°€λ²ˆν˜Έ μ΄ˆκΈ°ν™” 링크 볡사 κΈ°λŠ₯κ³Ό μ‚¬μš©μž 선택 λͺ©λ‘μ— μž‘μ€ UX 및 μ ‘κ·Όμ„± κ°œμ„ μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

  • μƒνƒœ ν”Όλ“œλ°±: κΈ°μ‘΄μ—λŠ” 링크λ₯Ό λ³΅μ‚¬ν•˜λ©΄ λ²„νŠΌ ν…μŠ€νŠΈκ°€ 'Copied'둜 λ³€κ²½λœ ν›„ μ˜μ›νžˆ λŒμ•„μ˜€μ§€ μ•Šμ•˜κ³ , μ•„μ΄μ½˜λ„ λ³€ν•˜μ§€ μ•Šμ•„ μ‹œκ°μ  ν”Όλ“œλ°±μ΄ λΆˆμΆ©λΆ„ν–ˆμŠ΅λ‹ˆλ‹€. 2초 ν›„ 초기 μƒνƒœλ‘œ 되돌리고 Check μ•„μ΄μ½˜μ„ ν‘œμ‹œν•˜μ—¬ λ”μš± μžμ—°μŠ€λŸ¬μš΄ μƒν˜Έμž‘μš©μ„ λ§Œλ“­λ‹ˆλ‹€.
  • ν‚€λ³΄λ“œ λ‚΄λΉ„κ²Œμ΄μ…˜: μ‚¬μš©μž λͺ©λ‘μ„ ν‚€λ³΄λ“œλ‘œ 탐색할 λ•Œ μ–΄λŠ ν•­λͺ©μ— ν¬μ»€μŠ€κ°€ μžˆλŠ”μ§€ λͺ…ν™•ν•˜κ²Œ μ•Œ 수 μžˆλ„λ‘ focus-visible 고리λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • 슀크린 리더 지원: μ„ νƒλœ μ‚¬μš©μžλ₯Ό 슀크린 리더가 λͺ…ν™•νžˆ 인지할 수 μžˆλ„λ‘ aria-current="true"λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

(ν”„λ‘ νŠΈμ—”λ“œ 검증 슀크립트λ₯Ό 톡해 확인됨)

  • Before: "Copy link"λ₯Ό λˆŒλŸ¬λ„ ν…μŠ€νŠΈλ§Œ "Copied"둜 λ°”λ€Œκ³ , μ•„μ΄μ½˜μ€ κ·ΈλŒ€λ‘œμž…λ‹ˆλ‹€. λ²„νŠΌ 선택 μ‹œ 포컀슀 링이 μ—†μŠ΅λ‹ˆλ‹€.
  • After: "Copy link" 클릭 μ‹œ ν…μŠ€νŠΈ λ³€κ²½κ³Ό ν•¨κ»˜ 2초 λ™μ•ˆ Check μ•„μ΄μ½˜μ΄ ν‘œμ‹œλ˜λ©°, μ‚¬μš©μž λͺ©λ‘μ„ νƒ­μœΌλ‘œ 이동할 λ•Œ 포컀슀 링이 μ„ λͺ…ν•˜κ²Œ λ‚˜νƒ€λ‚©λ‹ˆλ‹€.

β™Ώ Accessibility

  • μ‚¬μš©μž λͺ©λ‘ <button>에 aria-current={selected ? 'true' : undefined} 적용.
  • μ‚¬μš©μž λͺ©λ‘ <button>에 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ring 클래슀 μΆ”κ°€.

PR created automatically by Jules for task 12925237939853966349 started by @seonghobae

- `admin-dashboard.tsx`μ—μ„œ 링크 볡사 μ‹œ `setTimeout`을 μ‚¬μš©ν•˜μ—¬ 2초 ν›„ μ›λž˜ μƒνƒœλ‘œ λ³΅μ›λ˜λ„λ‘ μˆ˜μ •
- ν΄λ¦½λ³΄λ“œ 볡사 성곡 μ‹œ `Copy` μ•„μ΄μ½˜μ„ `Check` μ•„μ΄μ½˜μœΌλ‘œ μ‹œκ°μ  ν”Όλ“œλ°± 제곡
- μ‚¬μš©μž λͺ©λ‘μ˜ λ²„νŠΌλ“€μ— λŒ€ν•΄ ν‚€λ³΄λ“œ 포컀슀 μŠ€νƒ€μΌ(`focus-visible` 클래슀) μΆ”κ°€
- μ„ νƒλœ μ‚¬μš©μžμ— λŒ€ν•΄ `aria-current="true"` 속성 λΆ€μ—¬ν•˜μ—¬ 슀크린 리더 μ ‘κ·Όμ„± κ°•ν™”
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant