π‘οΈ Sentinel: [Medium] Fix bcrypt CPU exhaustion (DoS) vulnerability#277
π‘οΈ Sentinel: [Medium] Fix bcrypt CPU exhaustion (DoS) vulnerability#277seonghobae wants to merge 1 commit into
Conversation
- bcrypt ν΄μ± μκ³ λ¦¬μ¦μ CPU κ³ κ°μ μ΄μ©ν DoS 곡격(Denial of Service)μ λ°©μ§νκΈ° μν΄ μ¬μ©μμ κ΄λ¦¬μμ λΉλ°λ²νΈ μ΅λ κΈΈμ΄λ₯Ό 1024μλ‘ μ ννμ΅λλ€. - μν₯λ°λ μ€ν€λ§: AdminLoginSchema, ResetPasswordSchema, LoginRequestSchema, RegisterRequestSchema
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability:
Zod λΉλ°λ²νΈ κ²μ¦ μ€ν€λ§μ μ΅λ κΈΈμ΄ μ νμ΄ μμμ΅λλ€.
bcryptν΄μ± μκ³ λ¦¬μ¦μ νΉμ±μ μ§λμΉκ² κΈ΄ λ¬Έμμ΄(μ λ©κ°λ°μ΄νΈ λ±)μ΄ μ λ ₯λ κ²½μ°, ν΄μ± μ°μ°μ λ§λν CPU μμμ΄ μλͺ¨λ©λλ€.π― Impact:
μ μμ μΈ μ¬μ©μκ° λ¬΄νν κΈ΄ λΉλ°λ²νΈ λ¬Έμμ΄μ λ°λ³΅μ μΌλ‘ μ μΆνμ¬ μλ²μ CPUλ₯Ό μ μ νκ³ , κ²°κ³Όμ μΌλ‘ μλΉμ€ κ±°λΆ(DoS, Denial of Service) μνλ₯Ό μ λ°ν μ μμ΅λλ€.
π§ Fix:
@argos/webμAdminLoginSchema,ResetPasswordSchemaμ.max(1024)μ νμ μΆκ°νμ΅λλ€.@argos/sharedμLoginRequestSchema,RegisterRequestSchemaμ.max(1024)μ νμ μΆκ°νμ΅λλ€..jules/sentinel.mdμ λμ bcrypt DoS κ΄λ ¨ μ€μν 보μ νμ΅ λ΄μ©μ κΈ°λ‘νμ΅λλ€.β Verification:
pnpm test --recursiveλ°typecheck,lintλͺ λ Ήμ΄λ₯Ό ν΅ν΄ κΈ°μ‘΄ ν μ€νΈμ λΆμμ©μ΄ μμμ νμΈνμ΅λλ€.PR created automatically by Jules for task 3700071408403463610 started by @seonghobae