Repository navigation
fix(dasp_signal): make boxed feature actually build the intended module - #2
Closed
AlexTMjugador wants to merge 2 commits into
Closed
AlexTMjugador wants to merge 2 commits into
AlexTMjugador wants to merge 2 commits into
Conversation
…htlies Rust PR rust-lang/rust#160989, which is already part of the latest 1.100 nightlies, changed several unstable `core::intrinsics` functions to be generic, which implied a breaking name change. Unfortunately, these are used by `dasp_signal` when the `std` feature is not enabled. These changes make `dasp_signal` use the new intrinsic names, so that builds without the `std` feature work again on the latest nightlies. People that have to keep using older nightlies for any reason may temporarily pin their dependency on `dasp_signal` to a version compatible with their nightly build. While at it, I have also realized that such intrinsics have not been unsafe for a while now, so I removed their surrounding `unsafe` blocks.
AlexTMjugador
added this pull request to stack #3
September 27, 2026 14:08
AlexTMjugador
removed this pull request from stack #3
September 27, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on RustAudio#204, a relatively recently-introduced compiler warning about
featuresnot being a recognizedcfgcondition name caught my attention. After taking a look at the underlying code, I realized that it had the consequence of rendering theboxedfeature ofdasp_signalnon-functional, since it always evaluated to false and thus theboxedmodule containing aSignalimplementation for boxed signals was not compiled in.To fix that, these changes correct the identified
cfgtypo.Stack created with GitHub Stacks CLI • Give Feedback 💬