[T3410] other fixes after the second failing test - #396
Merged
Merged
Conversation
my_compassion_native had no i18n/ directory at all despite shipping several donor-facing strings, so they always rendered in English regardless of the viewer's language: the mobile bottom-nav tab labels, the profile page's buttons and subtitle, the two "new letter" push notification strings, and the three payment-status banners shown during the native-app payment flow. Translated into fr_CH, de and it (the three languages MyCompassion CH actually serves), reusing this brand's already-established wording from my_compassion's own translations wherever an equivalent string already existed there. Left the ~37 backend-only admin strings (field labels, wizard forms, help text) untranslated - internal Compassion staff use the backend in English regardless, and they were not part of what was reported.
Used Bootstrap 4 toggle syntax (data-toggle/data-target) while the rest of this codebase is on Bootstrap 5 (data-bs-toggle/data-bs-target), which doesn't recognize the unprefixed attributes at all - so clicking never wired up the collapse panel.
Contributor
 |
Odoo only delivers a module's JS (_t()) translations to the browser if
the module explicitly registers itself in
_get_translation_frontend_modules_name() (defaults to ['web'] only, per
core's own http_routing/models/ir_http.py). my_compassion and
theme_compassion_2025 both already do this for themselves;
my_compassion_native had no ir_http.py at all, so its 3
payment_resume.js strings would stay in English everywhere - not a
local/dev quirk, a permanent gap regardless of environment - despite
having correct .po entries.
Verified via code_translations.get_web_translations('my_compassion_native',
'fr_CH'): all 3 translated strings are now retrieved correctly through the
actual delivery mechanism.
Danielgergely
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer and the settings page were not being translated on mobile phones. Now on mobile phones: