fix(agent): normalize controller-owned registry identities

[scttbnsn]

Closes #687

What changed

• normalize complete controller-owned Portwing image records through the existing configured-provider path
• use the canonical registry name, URL, credentials, and image identity before persistence and native refresh
• preserve traditional agent behavior and partial-event handling
• cover initial inventory and subsequent Portwing event ingestion

Verification

• RED: both inventory and event paths retained registry.name=unknown and skipped the native registry query
• GREEN: affected AgentClient/image-comparison suite 607/607
• full backend 12,872 tests at 100% coverage on the fix commit
• full pre-push gate passed in 276 seconds after current-dev integration
• live exact-commit tri-tool smoke returned watch-now HTTP 200, queried hub.public, detected BusyBox 1.36.1, made 46 native Docker GETs, and made zero legacy watcher POSTs

Changelog

• ✨ Added controller-side normalization for Portwing containers from Docker transport watchers.
• 🔧 Changed inventory and incremental event handling to use configured registry identity, URL, credentials, and image identity.
• 🔧 Preserved traditional agent normalization and partial-event handling.
• 🐛 Fixed controller-owned registry checks for agent-synced containers.
• ✨ Added tests for anonymous Docker Hub registration, image normalization, and native watcher identity.
• 🔧 Verified affected tests, the backend suite, the pre-push gate, and live tri-tool smoke tests.

[vercel]

Deployment failed for project drydock-website with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/codeswhat?upgradeToPro=build-rate-limit

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8daa41d1-4685-4e63-a9cf-aa2ea1f84c4a

📥 Commits

Reviewing files that changed from the base of the PR and between 4fc35c7 and f8bb4f6.

📒 Files selected for processing (2)

• app/agent/AgentClient.test.ts
• app/agent/AgentClient.ts

---

📝 Walkthrough

Walkthrough

AgentClient now imports normalizeContainer and applies it to containers received through controller-native Docker transport when a registry URL is configured. Controller-owned enrichment remains after normalization. Tests type and reset mocked registry state, register an anonymous public Hub, and verify normalized Docker Hub data for marker-mode inventory and incremental watcher events.

Possibly related PRs

• CodesWhat/drydock#650: Introduces the controller-owned Docker transport extended by this normalization change.
• CodesWhat/drydock#651: Adds the controller-native transport and watcher infrastructure used by these AgentClient changes.
• CodesWhat/drydock#512: Earlier AgentClient changes are extended with controller-side Docker image and registry normalization.

Merge Risk: ⚪ Minimal · up to f8bb4

This change normalizes controller-owned registry identities while preserving existing agent behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes implement controller-side normalization for Docker transport during initial inventory and incremental events, addressing the controller execution boundary in issue [#687].
Out of Scope Changes check	✅ Passed	The implementation and tests remain limited to controller-owned registry normalization, native watcher identity, and preservation of traditional agent behavior.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/portwing-native-registry

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[scttbnsn]

@greptileai Review exact head f8bb4f635ae72fe01dd3f2eeb8ba3eb40e070283. Review the Portwing controller-owned Docker ingest boundary: exact marker gating, configured registry/provider normalization, credential and image-name semantics, preservation of controller enrichment, partial/legacy event behavior, and native watch-now registry lookup.

[greptile-apps]

Greptile Summary

The PR normalizes complete controller-owned Portwing container images through configured registry providers before persistence and native refresh, while retaining the existing enrichment-preservation behavior.

• Gates normalization to Docker API watchers using controller execution and Portwing events.
• Canonicalizes registry identity, URL, credentials selection, and image name through normalizeContainer.
• Adds inventory and incremental-event coverage for Docker Hub normalization and native watcher refresh.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified in the changed normalization paths.

The controller-owned transport gate precisely matches Portwing Docker API watchers, complete image records are normalized before persistence and native refresh, and controller enrichment remains preserved afterward.

Important Files Changed

Filename	Overview
app/agent/AgentClient.ts	Adds narrowly gated provider normalization before controller enrichment preservation; no concrete changed-code defect was established.
app/agent/AgentClient.test.ts	Adds regression coverage for canonical Docker Hub identities in initial inventory and subsequent Portwing event refresh paths.

_{Reviews (1): Last reviewed commit: "chore: merge dev/v1.7 into native regist..." | Re-trigger Greptile}

[biggest-littlest]

Reviewed exact final head. Controller-transport gating, provider normalization, enrichment preservation, legacy behavior, live tri-tool proof, and the complete CI/reviewer gates are covered.