🐛 fix(api): explicit 501 for agent containers without controller lifecycle transport

[scttbnsn]

Refs #637 (closed by #651's native-transport half in rc.11 — this is the remaining explicit-error half, matching #650's unresolved review concern).

Start/stop/restart and backup rollback returned a bare 404 NO_DOCKER_TRIGGER_FOUND_ERROR for agent-owned containers whose agent doesn't advertise usesControllerDockerTransport — indistinguishable from container-not-found. Worse, a legacy AgentTrigger without transport could still be found and then throw in getWatcher(), producing a 500.

• New AgentClient.hasControllerDockerTransport(watcherName) + isAgentLifecycleUnsupported(container): the 501 decision keys on the agent's actual capability, not trigger absence (Codex review caught the found-then-throw 500 path and the transient-miss mislabel).
• Agent known + no transport → 501 AGENT_LIFECYCLE_UNSUPPORTED_ERROR (in container-actions.ts AND backup.ts rollback — the adversarial round caught rollback had the identical defect).
• Agent known + capable + trigger transiently missing → existing 404 unchanged. Non-agent containers → unchanged.
• OpenAPI 501 entries added for all four routes.

Review provenance: adversarial verify round (2 findings, repaired), independent Codex review (1 finding, repaired), re-verified approve, full app suite green.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
drydock-website	Ready	Preview	Aug 4, 2026 8:58pm
drydockdemo-website	Ready	Preview	Aug 4, 2026 8:58pm

[coderabbitai]

Warning

Review limit reached

@scttbnsn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 82185c48-ff4d-4baa-8b34-c198600d2aae

📥 Commits

Reviewing files that changed from the base of the PR and between c4cd8e0 and 0fbc3f1.

⛔ Files ignored due to path filters (1)

• CHANGELOG.md is excluded by !CHANGELOG.md

📒 Files selected for processing (9)

• app/agent/AgentClient.test.ts
• app/agent/AgentClient.ts
• app/api/backup.test.ts
• app/api/backup.ts
• app/api/container-actions.test.ts
• app/api/container-actions.ts
• app/api/docker-trigger.ts
• app/api/openapi/paths/containers.test.ts
• app/api/openapi/paths/containers.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vercel]

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/codeswhat?upgradeToPro=build-rate-limit